Re: [PR] Ensure statistic defaults in parquet writers are in sync [datafusion]

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #11656:
URL: https://github.com/apache/datafusion/pull/11656#discussion_r1693130571


##########
datafusion/sqllogictest/test_files/information_schema.slt:
##########
@@ -202,7 +202,7 @@ datafusion.execution.parquet.pruning true
 datafusion.execution.parquet.pushdown_filters false
 datafusion.execution.parquet.reorder_filters false
 datafusion.execution.parquet.skip_metadata true
-datafusion.execution.parquet.statistics_enabled NULL
+datafusion.execution.parquet.statistics_enabled page

Review Comment:
   I think this is an improvement -- it doesn't change the default value (`NULL` means use arrow-rs defaults, which is `page`), but now the default value isexplicit in the config settings
   
   Also there is a test to ensure the defaults don't drift from the arrow-rs defaults accidentally



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org