You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2017/07/18 17:54:04 UTC

[GitHub] storm pull request #2223: STORM-2541: Fix manual partition assignment (1.x)

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2223

    STORM-2541: Fix manual partition assignment (1.x)

    Same as https://github.com/apache/storm/pull/2150, but for 1.x.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-2541-1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2223
    
----
commit fd5593da77ddb01dad18ed71de604e3fdbe40a49
Author: Stig Rohde Døssing <st...@gmail.com>
Date:   2017-06-05T12:59:19Z

    STORM-2541: Fix storm-kafka-client manual subscription not being able to start consuming

commit b2eb5bf2a93848fde47183700de5078a0b69980b
Author: Stig Rohde Døssing <sr...@apache.org>
Date:   2017-07-18T17:51:04Z

    STORM-2541: Replace String.join with Java 7 version

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2223: STORM-2541: Fix manual partition assignment (1.x)

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2223
  
    The only change from the master version is replacing String.join with StringUtils.join in the topic filters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2223: STORM-2541: Fix manual partition assignment (1.x)

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2223
  
    Thanks for reviewing. The test failure was an unrelated bit of flakiness in the integration test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2223: STORM-2541: Fix manual partition assignment (1.x)

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2223


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2223: STORM-2541: Fix manual partition assignment (1.x)

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2223
  
    +1
    I'm OK to break the API if it didn't work anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---