You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2023/01/17 19:19:21 UTC

[GitHub] [opennlp] rzo1 opened a new pull request, #491: OPENNLP-1445 - Run GH action "Publish snapshots" only on ASF repo

rzo1 opened a new pull request, #491:
URL: https://github.com/apache/opennlp/pull/491

   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - x ] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   
   - Don't run publish snapshots on forked repositories (as they do not have the secrets available and will fail as reported by @mawiesne )
   
   - Similar fix / action as done by Spark in https://github.com/apache/spark/blob/master/.github/workflows/publish_snapshot.yml#L28
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp] rzo1 commented on pull request #491: OPENNLP-1445 - Run GH action "Publish snapshots" only on ASF repo

Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #491:
URL: https://github.com/apache/opennlp/pull/491#issuecomment-1386570275

   Thanks for the reviews!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp] rzo1 merged pull request #491: OPENNLP-1445 - Run GH action "Publish snapshots" only on ASF repo

Posted by GitBox <gi...@apache.org>.
rzo1 merged PR #491:
URL: https://github.com/apache/opennlp/pull/491


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org