You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/15 14:21:01 UTC
[GitHub] [spark] sander-goos opened a new pull request #30783: [SPARK-33793][TESTS] Refactor usage of Executors to establish a pattern maki…
sander-goos opened a new pull request #30783:
URL: https://github.com/apache/spark/pull/30783
### What changes were proposed in this pull request?
This PR introduces a helper method `withExecutor` that handles the creation of an Executor object and ensures that it is always stopped in a finally block. The tests in ExecutorSuite have been refactored to use this method.
### Why are the changes needed?
Recently an issue was discovered that leaked Executors (which are not explicitly stopped after a test) can cause other tests to fail due to the JVM being killed after 10 min. It is therefore crucial that tests always stop the Executor. By introducing this helper method, a simple pattern is established that can be easily adopted in new tests, which reduces the risk of regressions.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Run the ExecutorSuite locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30783: [SPARK-33793][TESTS] Introduce withExecutor to ensure proper cleanup in tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30783:
URL: https://github.com/apache/spark/pull/30783#issuecomment-745722024
**[Test build #132852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132852/testReport)** for PR 30783 at commit [`87faa5a`](https://github.com/apache/spark/commit/87faa5ae8576d7df574e3e4032ad3dde7f2ab044).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30783: [SPARK-33793][TESTS] Introduce withExecutor to ensure proper cleanup in tests
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30783:
URL: https://github.com/apache/spark/pull/30783#issuecomment-745722608
Merged to master and branch-3.1.
@sander-goos, it has a minor conflict against branch-3.0. Would you mind if I ask to open a backporting PR to `branch-3.0`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30783: [SPARK-33793][TESTS] Introduce withExecutor to ensure proper cleanup in tests
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30783:
URL: https://github.com/apache/spark/pull/30783#issuecomment-745720655
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30783: [SPARK-33793][TESTS] Introduce withExecutor to ensure proper cleanup in tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30783:
URL: https://github.com/apache/spark/pull/30783#issuecomment-745750359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30783: [SPARK-33793][TESTS] Introduce withExecutor to ensure proper cleanup in tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30783:
URL: https://github.com/apache/spark/pull/30783#issuecomment-745315956
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30783: [SPARK-33793][TESTS] Introduce withExecutor to ensure proper cleanup in tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30783:
URL: https://github.com/apache/spark/pull/30783#issuecomment-745743453
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37454/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30783: [SPARK-33793][TESTS] Introduce withExecutor to ensure proper cleanup in tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30783:
URL: https://github.com/apache/spark/pull/30783#issuecomment-745750359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30783: [SPARK-33793][TESTS] Introduce withExecutor to ensure proper cleanup in tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30783:
URL: https://github.com/apache/spark/pull/30783#issuecomment-745315956
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sander-goos commented on pull request #30783: [SPARK-33793][TESTS] Introduce withExecutor to ensure proper cleanup in tests
Posted by GitBox <gi...@apache.org>.
sander-goos commented on pull request #30783:
URL: https://github.com/apache/spark/pull/30783#issuecomment-746075094
> Merged to master and branch-3.1.
>
> @sander-goos, it has a minor conflict against branch-3.0. Would you mind if I ask to open a backporting PR to `branch-3.0`?
Thanks for merging. Sure, here is the backport: https://github.com/apache/spark/pull/30801
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30783: [SPARK-33793][TESTS] Introduce withExecutor to ensure proper cleanup in tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30783:
URL: https://github.com/apache/spark/pull/30783#issuecomment-745734442
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37454/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30783: [SPARK-33793][TESTS] Introduce withExecutor to ensure proper cleanup in tests
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30783:
URL: https://github.com/apache/spark/pull/30783
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org