[GitHub] [arrow-rs] viirya commented on a diff in pull request #2360: Speed up `Decimal256` validation based on bytes comparison and add benchmark test

[GitBox <gi...@apache.org>]

viirya commented on code in PR #2360:
URL: https://github.com/apache/arrow-rs/pull/2360#discussion_r943961064


##########
arrow/src/datatypes/datatype.rs:
##########
@@ -263,6 +265,626 @@ impl fmt::Display for DataType {
     }
 }
 
+// MAX decimal256 value of little-endian format for each precision.
+// Each element is the max value of signed 256-bit integer for the specified precision which
+// is encoded to the 76-byte width format of little-endian.

Review Comment:
   ```suggestion
   // is encoded to the 32-byte width format of little-endian.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org