You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Dian Fu <di...@gmail.com> on 2015/09/06 10:43:42 UTC
Review Request 38147: Sqoop2: Kite connector documention note on
dataset URIs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38147/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2374
https://issues.apache.org/jira/browse/SQOOP-2374
Repository: sqoop-sqoop2
Description
-------
Kite connector documentation should note: "Dataset uri of TO-direction is complete, the authority of Link will be ignored".
Diffs
-----
docs/src/site/sphinx/Connectors.rst 41571ba
Diff: https://reviews.apache.org/r/38147/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 38147: Sqoop2: Kite connector documention note on
dataset URIs
Posted by Dian Fu <di...@gmail.com>.
> On Sept. 7, 2015, 4:09 a.m., Qian Xu wrote:
> > docs/src/site/sphinx/Connectors.rst, line 432
> > <https://reviews.apache.org/r/38147/diff/1/?file=1064727#file1064727line432>
> >
> > I'd prefer such a note: `If the given dataset URI contains authority, the authority from the link configuration will be ignored.`
Thanks Qian for the comments. Make sense to me. Updated the patch accordingly.
- Dian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38147/#review97888
-----------------------------------------------------------
On Sept. 7, 2015, 5:07 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38147/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2015, 5:07 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2374
> https://issues.apache.org/jira/browse/SQOOP-2374
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Kite connector documentation should note: "Dataset uri of TO-direction is complete, the authority of Link will be ignored".
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/Connectors.rst 41571ba
>
> Diff: https://reviews.apache.org/r/38147/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 38147: Sqoop2: Kite connector documention note on
dataset URIs
Posted by Qian Xu <qi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38147/#review97888
-----------------------------------------------------------
docs/src/site/sphinx/Connectors.rst (line 432)
<https://reviews.apache.org/r/38147/#comment153959>
I'd prefer such a note: `If the given dataset URI contains authority, the authority from the link configuration will be ignored.`
- Qian Xu
On Sept. 6, 2015, 4:43 p.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38147/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2015, 4:43 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2374
> https://issues.apache.org/jira/browse/SQOOP-2374
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Kite connector documentation should note: "Dataset uri of TO-direction is complete, the authority of Link will be ignored".
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/Connectors.rst 41571ba
>
> Diff: https://reviews.apache.org/r/38147/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 38147: Sqoop2: Kite connector documention note on
dataset URIs
Posted by Qian Xu <qi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38147/#review97896
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Xu
On Sept. 7, 2015, 1:07 p.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38147/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2015, 1:07 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2374
> https://issues.apache.org/jira/browse/SQOOP-2374
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Kite connector documentation should note: "Dataset uri of TO-direction is complete, the authority of Link will be ignored".
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/Connectors.rst 41571ba
>
> Diff: https://reviews.apache.org/r/38147/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 38147: Sqoop2: Kite connector documention note on
dataset URIs
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38147/
-----------------------------------------------------------
(Updated Sept. 7, 2015, 5:07 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2374
https://issues.apache.org/jira/browse/SQOOP-2374
Repository: sqoop-sqoop2
Description
-------
Kite connector documentation should note: "Dataset uri of TO-direction is complete, the authority of Link will be ignored".
Diffs (updated)
-----
docs/src/site/sphinx/Connectors.rst 41571ba
Diff: https://reviews.apache.org/r/38147/diff/
Testing
-------
Thanks,
Dian Fu