You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/21 16:59:24 UTC

[GitHub] [iotdb] jixuan1989 commented on issue #4851: backtick escape character handled inconsistently by CLI and Java API when create timeseries

jixuan1989 commented on issue #4851:
URL: https://github.com/apache/iotdb/issues/4851#issuecomment-1018689391


   @liuminghui233  
   
   > For the checkTimeseriesExists interface, since the IoTDB-SQL interface is called internally, the time-series pathname must be consistent with the SQL syntax conventions and be escaped for JAVA strings.
   
   This may cause some potential bugs: can we make sure all callers know the semantic?
   
   For example, if someone implement a new Java interface like `createTimeseries`, and in the implementation, he/she calls `checkTimeseriesExists`... (Don't we call `checkTimeseriesExists` in our `createTimeseries` method?)
   
   Considering the above, I think adding a new function `checkTimeseriesExistsWithSQL ` may be fine. @coolbeevip 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org