[I] Instance settings lost after snapshot rollback [cloudstack]

["pdiego98 (via GitHub)" <gi...@apache.org>]

pdiego98 opened a new issue, #13153:
URL: https://github.com/apache/cloudstack/issues/13153

   ### problem
   
   When a snapshot is created and then rolled back, the instance settings are lost.
   In our case after restore rootDiskController, nicAdapter, io.policy, nic.multiqueue.number and iothreads settings disappeared.
   We have reproduced the issue in two separete ACS, one at version 4.22.0.0 and one at 4.22.0.1.
   
   
   ### versions
   
   Our setup is
   ACS 4.22.0.0 or 4.22.0.1 on Ubuntu 22.04.
   KVM hosts with qemu 9.1.0-15.el9_6.7.x86_64 and 
   Local XFS storage
   
   ### The steps to reproduce the bug
   
   1. Create an instance, the problem is for both instances created with a template containing the custom setting and instances with additional setting added after creation.
   2. If not already present from template, add some settings to instance like root disk controller type or nicadapter type
   3. Create a snapshot of the instance
   4. Rollback the snapshot
   5. Check for the additional setting, they should be gone
   
   ### What to do about it?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Instance settings lost after snapshot rollback [cloudstack]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on issue #13153:
URL: https://github.com/apache/cloudstack/issues/13153#issuecomment-5330090838

   ## 🎯 Triage report
   
   After creating an instance snapshot and rolling it back, custom instance details (rootDiskController, nicAdapter, io.policy, nic.multiqueue.number, iothreads) are lost, regardless of whether they were set via template or added post-creation. Reproduced independently on two ACS deployments (4.22.0.0 and 4.22.0.1).
   
   ### 📊 Assessment
   
   | Dimension | Value | Reasoning |
   |---|---|---|
   | **Type** | type:bug | Clear, reproducible data-loss-on-rollback defect with detailed repro steps across two deployments |
   | **Component** | component:kvm | Instance details affected (disk controller, NIC adapter, iothreads) are KVM/libvirt-specific settings; snapshot/rollback flow also involved |
   | **Severity** | Severity:Major | Custom hardware/performance settings silently reverting after rollback can cause unexpected VM behavior/performance regressions post-recovery |
   | **Labels** | type:bug, component:kvm | |
   | **Coding agent** | Suitable | Well-defined, reproducible scope: instance snapshot rollback should preserve `user_vm_details` entries; clear 5-step repro provided |
   
   ### 🔗 Similar issues
   
   No close duplicates found; other keyword matches (#7358, #7942, #6698) are closed and address unrelated problems.
   
   <details><summary>💡 Notes and suggestions</summary>
   
   - Likely area: the VM snapshot rollback code path that restores the VM record but does not restore/preserve associated `user_vm_details` rows captured at snapshot time.
   - Suggest checking whether instance details are captured as part of the VM snapshot payload at all, or only the VM/volume state; if not captured, the fix would need to snapshot and restore those details too.
   
   </details>
   
   
   
   > Generated by [Daily Issue Triage](https://github.com/apache/cloudstack/actions/runs/32143747223) · sonnet50 259.3K · [◷](https://github.com/search?q=repo%3Aapache%2Fcloudstack+%22gh-aw-workflow-call-id%3A+apache%2Fcloudstack%2Fdaily-issue-triage%22&type=issues)
   >
   <details>
   <summary>Add this agentic workflows to your repo</summary>
   
   To install this agentic workflow, run
   
   ```
   gh aw add githubnext/agentics/workflows/daily-issue-triage.md@d7c1dc4b72b00607a67caaffdcc216cb64379cf9
   ```
   </details>
   
   
   <!-- gh-aw-agentic-workflow: Daily Issue Triage, engine: copilot, version: 1.0.52, model: claude-sonnet-5, id: 32143747223, workflow_id: daily-issue-triage, run: https://github.com/apache/cloudstack/actions/runs/32143747223 -->
   <!-- gh-aw-workflow-call-id: apache/cloudstack/daily-issue-triage -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Instance settings lost after snapshot rollback [cloudstack]

["boring-cyborg[bot] (via GitHub)" <gi...@apache.org>]

boring-cyborg[bot] commented on issue #13153:
URL: https://github.com/apache/cloudstack/issues/13153#issuecomment-4438894655

   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org