[GitHub] [arrow] pitrou commented on a diff in pull request #36228: GH-36227: [C++] New GcsOption to set the project id

["pitrou (via GitHub)" <gi...@apache.org>]

pitrou commented on code in PR #36228:
URL: https://github.com/apache/arrow/pull/36228#discussion_r1246637351


##########
cpp/src/arrow/filesystem/gcsfs.h:
##########
@@ -77,6 +83,13 @@ struct ARROW_EXPORT GcsOptions {
   /// This will be ignored if non-empty metadata is passed to OpenOutputStream.
   std::shared_ptr<const KeyValueMetadata> default_metadata;
 
+  /// \brief The project to use for creating buckets.
+  ///
+  /// If not set, the library uses the GOOGLE_CLOUD_PROJECT environment
+  /// variable. Most I/O operations do not need a project id, only applications
+  /// that create new buckets need a project id.
+  std::optional<std::string> project_id;

Review Comment:
   FTR, an optional was probably not necessary as I suppose an empty string cannot possibly be a valid project id?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org