[GitHub] [arrow-ballista] zhzy0077 opened a new pull request, #732: tpch conversion is failling with ArrowError(CsvError)

["zhzy0077 (via GitHub)" <gi...@apache.org>]

zhzy0077 opened a new pull request, #732:
URL: https://github.com/apache/arrow-ballista/pull/732

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   This is - to me - a utility change, so I don't create a bug.
   Closes #.
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   benchmarks/src/bin/tpch.rs is failing to convert TPC-H's tbl file to parquet file.
   because there's a tailing '|' in the tbl file like this:
   ```
   1|goldenrod lavender spring chocolate lace|Manufacturer#1|Brand#13|PROMO BURNISHED COPPER|7|JUMBO PKG|901.00|ly. slyly ironi|
   ```
   So Arrow believes the schema doesn't match CSV itself and throws `Error: ArrowError(CsvError("incorrect number of fields for line 1, expected 9 got more than 9"))`
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   Adds an null-able trailing field to the schema so CSV parsing won't fail.
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   No
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] XiangpengHao commented on pull request #732: tpch conversion is failling with ArrowError(CsvError)

["XiangpengHao (via GitHub)" <gi...@apache.org>]

XiangpengHao commented on PR #732:
URL: https://github.com/apache/arrow-ballista/pull/732#issuecomment-1522275173

   Strange that the same benchmark in DataFusion works fine. https://github.com/apache/arrow-datafusion/blob/main/benchmarks/src/tpch.rs#L69
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org