[jira] [Commented] (CB-13304) Forward non file:// URLs to system

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-13304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173969#comment-16173969 ] 

ASF GitHub Bot commented on CB-13304:
-------------------------------------

GitHub user albertolalama opened a pull request:

    https://github.com/apache/cordova-osx/pull/41

    CB-13304: open file:// URLs in-app, forward others to the system

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    OSX
    
    ### What does this PR do?
    Forwards non file:// URL requests to the system instead of opening them inside the application.
    
    ### What testing has been done on this change?
    Tested locally.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/albertolalama/cordova-osx alalama-url-navigation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-osx/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #41
    
----
commit 402acb1d682bec7b06fd7664a61a58fe5e288e69
Author: alberto lalama <al...@users.noreply.github.com>
Date:   2017-09-20T22:48:59Z

    CB-13304: open file:// URLs in-app, forward others to the system

----


> Forward non file:// URLs to system
> ----------------------------------
>
>                 Key: CB-13304
>                 URL: https://issues.apache.org/jira/browse/CB-13304
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-osx
>    Affects Versions: 4.0.1
>            Reporter: Alberto Lalama
>            Assignee: Tobias Bocanegra
>
> The WebView delegate opens all URL requests in-app. This is necessary to load local assets, but not desirable for opening non file:// URLs (i.e. http/https). The latter should be handled by the system, that is, open in the user's default browser.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org