You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Phil Steitz <ph...@gmail.com> on 2015/10/27 21:47:23 UTC
Re: [1/2] [math] MATH-1285: replaced inappropriate reference to
MathWorld by reference to Wikipedia's article about Zipf's law, thanks to Pim
van der Hoorn for reporting this issue
It would be good to actually describe the parameters (actually the
whole distribution) instead of expecting people to figure out what
is what from a (potentially changing) Wikipedia article.
On 10/27/15 12:45 PM, oertl@apache.org wrote:
> Repository: commons-math
> Updated Branches:
> refs/heads/MATH_3_X 40f35da56 -> 5f03f0d70
> refs/heads/master 9e0c5ad4b -> 8ed2209b1
>
>
> MATH-1285: replaced inappropriate reference to MathWorld by reference to
> Wikipedia's article about Zipf's law, thanks to Pim van der Hoorn for
> reporting this issue
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/8ed2209b
> Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/8ed2209b
> Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/8ed2209b
>
> Branch: refs/heads/master
> Commit: 8ed2209b1f8e2452d71ef8c3149f3ed3d89d4dfa
> Parents: 9e0c5ad
> Author: Otmar Ertl <ot...@gmail.com>
> Authored: Tue Oct 27 20:24:34 2015 +0100
> Committer: Otmar Ertl <ot...@gmail.com>
> Committed: Tue Oct 27 20:33:39 2015 +0100
>
> ----------------------------------------------------------------------
> src/changes/changes.xml | 3 +++
> .../org/apache/commons/math4/distribution/ZipfDistribution.java | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/commons-math/blob/8ed2209b/src/changes/changes.xml
> ----------------------------------------------------------------------
> diff --git a/src/changes/changes.xml b/src/changes/changes.xml
> index e18ba9f..55a8fcb 100644
> --- a/src/changes/changes.xml
> +++ b/src/changes/changes.xml
> @@ -54,6 +54,9 @@ If the output is not quite correct, check for invisible trailing spaces!
> </release>
>
> <release version="4.0" date="XXXX-XX-XX" description="">
> + <action dev="oertl" type="fix" issue="MATH-1285" due-to="Pim van der Hoorn "> <!-- backported to 3.6 -->
> + Updated reference in ZipfDistribution's javadoc.
> + </action>
> <action dev="tn" type="fix" issue="MATH-1283" due-to="Jean Noel Delavalade"> <!-- backported to 3.6 -->
> Fixed "Gamma#gamma(double)" for negative values smaller than -20.
> </action>
>
> http://git-wip-us.apache.org/repos/asf/commons-math/blob/8ed2209b/src/main/java/org/apache/commons/math4/distribution/ZipfDistribution.java
> ----------------------------------------------------------------------
> diff --git a/src/main/java/org/apache/commons/math4/distribution/ZipfDistribution.java b/src/main/java/org/apache/commons/math4/distribution/ZipfDistribution.java
> index 7fd62e1..5e7018c 100644
> --- a/src/main/java/org/apache/commons/math4/distribution/ZipfDistribution.java
> +++ b/src/main/java/org/apache/commons/math4/distribution/ZipfDistribution.java
> @@ -26,7 +26,7 @@ import org.apache.commons.math4.util.FastMath;
> /**
> * Implementation of the Zipf distribution.
> *
> - * @see <a href="http://mathworld.wolfram.com/ZipfDistribution.html">Zipf distribution (MathWorld)</a>
> + * @see <a href="https://en.wikipedia.org/wiki/Zipf's_law">Zipf's law (Wikipedia)</a>
> */
> public class ZipfDistribution extends AbstractIntegerDistribution {
> /** Serializable version identifier. */
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [1/2] [math] MATH-1285: replaced inappropriate reference to
MathWorld by reference to Wikipedia's article about Zipf's law, thanks to Pim
van der Hoorn for reporting this issue
Posted by Otmar Ertl <ot...@gmail.com>.
On Tue, Oct 27, 2015 at 9:47 PM, Phil Steitz <ph...@gmail.com> wrote:
> It would be good to actually describe the parameters (actually the
> whole distribution) instead of expecting people to figure out what
> is what from a (potentially changing) Wikipedia article.
>
The MathWorld article that was previously referenced describes a
distribution with infinite support and used a different
parameterization. Hence, the reference to this article was simply a
bug which I have quickly fixed by refering to a Wikipedia article that
matches to the distribution we actually have implemented. I agree, a
more detailed javadoc documentation would be better. I will reopen the
issue.
> On 10/27/15 12:45 PM, oertl@apache.org wrote:
>> Repository: commons-math
>> Updated Branches:
>> refs/heads/MATH_3_X 40f35da56 -> 5f03f0d70
>> refs/heads/master 9e0c5ad4b -> 8ed2209b1
>>
>>
>> MATH-1285: replaced inappropriate reference to MathWorld by reference to
>> Wikipedia's article about Zipf's law, thanks to Pim van der Hoorn for
>> reporting this issue
>>
>> Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/8ed2209b
>> Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/8ed2209b
>> Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/8ed2209b
>>
>> Branch: refs/heads/master
>> Commit: 8ed2209b1f8e2452d71ef8c3149f3ed3d89d4dfa
>> Parents: 9e0c5ad
>> Author: Otmar Ertl <ot...@gmail.com>
>> Authored: Tue Oct 27 20:24:34 2015 +0100
>> Committer: Otmar Ertl <ot...@gmail.com>
>> Committed: Tue Oct 27 20:33:39 2015 +0100
>>
>> ----------------------------------------------------------------------
>> src/changes/changes.xml | 3 +++
>> .../org/apache/commons/math4/distribution/ZipfDistribution.java | 2 +-
>> 2 files changed, 4 insertions(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/commons-math/blob/8ed2209b/src/changes/changes.xml
>> ----------------------------------------------------------------------
>> diff --git a/src/changes/changes.xml b/src/changes/changes.xml
>> index e18ba9f..55a8fcb 100644
>> --- a/src/changes/changes.xml
>> +++ b/src/changes/changes.xml
>> @@ -54,6 +54,9 @@ If the output is not quite correct, check for invisible trailing spaces!
>> </release>
>>
>> <release version="4.0" date="XXXX-XX-XX" description="">
>> + <action dev="oertl" type="fix" issue="MATH-1285" due-to="Pim van der Hoorn "> <!-- backported to 3.6 -->
>> + Updated reference in ZipfDistribution's javadoc.
>> + </action>
>> <action dev="tn" type="fix" issue="MATH-1283" due-to="Jean Noel Delavalade"> <!-- backported to 3.6 -->
>> Fixed "Gamma#gamma(double)" for negative values smaller than -20.
>> </action>
>>
>> http://git-wip-us.apache.org/repos/asf/commons-math/blob/8ed2209b/src/main/java/org/apache/commons/math4/distribution/ZipfDistribution.java
>> ----------------------------------------------------------------------
>> diff --git a/src/main/java/org/apache/commons/math4/distribution/ZipfDistribution.java b/src/main/java/org/apache/commons/math4/distribution/ZipfDistribution.java
>> index 7fd62e1..5e7018c 100644
>> --- a/src/main/java/org/apache/commons/math4/distribution/ZipfDistribution.java
>> +++ b/src/main/java/org/apache/commons/math4/distribution/ZipfDistribution.java
>> @@ -26,7 +26,7 @@ import org.apache.commons.math4.util.FastMath;
>> /**
>> * Implementation of the Zipf distribution.
>> *
>> - * @see <a href="http://mathworld.wolfram.com/ZipfDistribution.html">Zipf distribution (MathWorld)</a>
>> + * @see <a href="https://en.wikipedia.org/wiki/Zipf's_law">Zipf's law (Wikipedia)</a>
>> */
>> public class ZipfDistribution extends AbstractIntegerDistribution {
>> /** Serializable version identifier. */
>>
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org