You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/04/22 14:06:33 UTC
Review Request 46567: Passed argument by const-ref in command
executor's escalated().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46567/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/launcher/executor.cpp bec9cba091df2d1b340e68e67966ec322558c315
src/launcher/http_command_executor.cpp 9dfe48108cababeb2d4a6af74434880d79245c21
Diff: https://reviews.apache.org/r/46567/diff/
Testing
-------
`make check`
Thanks,
Alexander Rukletsov
Re: Review Request 46567: Passed argument by const-ref in command
executor's escalated().
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46567/#review130078
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On April 22, 2016, 2:06 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46567/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 2:06 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp bec9cba091df2d1b340e68e67966ec322558c315
> src/launcher/http_command_executor.cpp 9dfe48108cababeb2d4a6af74434880d79245c21
>
> Diff: https://reviews.apache.org/r/46567/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 46567: Passed argument by const-ref in command
executor's escalated().
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46567/#review130086
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46567]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 22, 2016, 12:06 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46567/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 12:06 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp bec9cba091df2d1b340e68e67966ec322558c315
> src/launcher/http_command_executor.cpp 9dfe48108cababeb2d4a6af74434880d79245c21
>
> Diff: https://reviews.apache.org/r/46567/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Alexander Rukletsov
>
>