You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/06/17 16:03:15 UTC
Review Request: Automation: (vpc network pf and lb rules) - Corrected code
related to cleanup.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11909/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Description
-------
Corrected code related to cleanup of VPC offering. self.vpc_off was added twice instead of vpc_off. That may lead to error in the cleanup process eventually leading to accounts and vpc offerings not being cleaned up.
Diffs
-----
test/integration/component/test_vpc_network_lbrules.py 66d6c4d
test/integration/component/test_vpc_network_pfrules.py 92b04ad
Diff: https://reviews.apache.org/r/11909/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request: Automation: (vpc network pf and lb rules) - Corrected
code related to cleanup.
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11909/#review21981
-----------------------------------------------------------
Ship it!
Applied but the test will fail because of a regression in the NetworkACL code. Details in CLOUDSTACK-2915
- Prasanna Santhanam
On June 17, 2013, 2:03 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11909/
> -----------------------------------------------------------
>
> (Updated June 17, 2013, 2:03 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> Corrected code related to cleanup of VPC offering. self.vpc_off was added twice instead of vpc_off. That may lead to error in the cleanup process eventually leading to accounts and vpc offerings not being cleaned up.
>
>
> Diffs
> -----
>
> test/integration/component/test_vpc_network_lbrules.py 66d6c4d
> test/integration/component/test_vpc_network_pfrules.py 92b04ad
>
> Diff: https://reviews.apache.org/r/11909/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>