[jira] [Created] (SSHD-202) SSH Client silently accepts server key by default :-(

["Andrew C (JIRA)" <ji...@apache.org>]

Andrew C created SSHD-202:
-----------------------------

             Summary: SSH Client silently accepts server key by default :-(
                 Key: SSHD-202
                 URL: https://issues.apache.org/jira/browse/SSHD-202
             Project: MINA SSHD
          Issue Type: Bug
    Affects Versions: 0.8.0
         Environment: Windows
            Reporter: Andrew C


The default SshClient, returned by SshClient.setUpDefaultClient, silently accepts the server's public key.  This is because ClientSessionImpl.checkHost allows a null ServerKeyVerifier and silently succeeds,  This is, IMNSHO, really bad.  Instead, I'd suggest:
- SshClient.checkConfig require a ServerKeyVerifier
- ClientSessionImpl.checkHost crash and burn when ServerKeyVerifier is null
- SshClient.setupDefaultClient set it to AcceptAllServerKeyVerifier (maintains compatibility)
- and AcceptAllServerKeyVerifier clearly log its action at the warning, not trace level
Tweaking RequiredServerKeyVerifier to log its actions would also be helpful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira