You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/08/07 15:04:57 UTC
Review Request 61462: Update Orchestration to support MAINT
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61462/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-21672
https://issues.apache.org/jira/browse/AMBARI-21672
Repository: ambari
Description
-------
Update orchestration to support VDF types of {{MAINT}}.
* Type {{PATCH}} and type {{MAINT}} should be treated the same for orchestration.
* If the available services loop has a {{release-version}} then use that to determine if a service should be included in orchestration.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java c5b8269547
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java e2bb27ed5b
Diff: https://reviews.apache.org/r/61462/diff/1/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
Re: Review Request 61462: Update Orchestration to support MAINT
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61462/#review182296
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Aug. 7, 2017, 11:04 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61462/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 11:04 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-21672
> https://issues.apache.org/jira/browse/AMBARI-21672
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update orchestration to support VDF types of {{MAINT}}.
> * Type {{PATCH}} and type {{MAINT}} should be treated the same for orchestration.
> * If the available services loop has a {{release-version}} then use that to determine if a service should be included in orchestration.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java c5b8269547
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java e2bb27ed5b
>
>
> Diff: https://reviews.apache.org/r/61462/diff/2/
>
>
> Testing
> -------
>
> Tests run: 4524, Failures: 0, Errors: 0, Skipped: 32
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:08 min
> [INFO] Finished at: 2017-08-07T12:54:08-04:00
> [INFO] Final Memory: 77M/1015M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 61462: Update Orchestration to support MAINT
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Aug. 7, 2017, 2:17 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
> > Lines 931 (patched)
> > <https://reviews.apache.org/r/61462/diff/2/?file=1790801#file1790801line971>
> >
> > Typo in orchestration
Do you cut/paste the code into a Google Doc and run spellcheck? :)
Thanks for the review! I'll fix the typo...
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61462/#review182301
-----------------------------------------------------------
On Aug. 7, 2017, 11:04 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61462/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 11:04 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-21672
> https://issues.apache.org/jira/browse/AMBARI-21672
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update orchestration to support VDF types of {{MAINT}}.
> * Type {{PATCH}} and type {{MAINT}} should be treated the same for orchestration.
> * If the available services loop has a {{release-version}} then use that to determine if a service should be included in orchestration.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java c5b8269547
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java e2bb27ed5b
>
>
> Diff: https://reviews.apache.org/r/61462/diff/2/
>
>
> Testing
> -------
>
> Tests run: 4524, Failures: 0, Errors: 0, Skipped: 32
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:08 min
> [INFO] Finished at: 2017-08-07T12:54:08-04:00
> [INFO] Final Memory: 77M/1015M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 61462: Update Orchestration to support MAINT
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61462/#review182301
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
Lines 931 (patched)
<https://reviews.apache.org/r/61462/#comment258186>
Typo in orchestration
- Alejandro Fernandez
On Aug. 7, 2017, 3:04 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61462/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 3:04 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-21672
> https://issues.apache.org/jira/browse/AMBARI-21672
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update orchestration to support VDF types of {{MAINT}}.
> * Type {{PATCH}} and type {{MAINT}} should be treated the same for orchestration.
> * If the available services loop has a {{release-version}} then use that to determine if a service should be included in orchestration.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java c5b8269547
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java e2bb27ed5b
>
>
> Diff: https://reviews.apache.org/r/61462/diff/2/
>
>
> Testing
> -------
>
> Tests run: 4524, Failures: 0, Errors: 0, Skipped: 32
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:08 min
> [INFO] Finished at: 2017-08-07T12:54:08-04:00
> [INFO] Final Memory: 77M/1015M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 61462: Update Orchestration to support MAINT
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61462/#review182281
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Aug. 7, 2017, 6:04 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61462/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 6:04 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-21672
> https://issues.apache.org/jira/browse/AMBARI-21672
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update orchestration to support VDF types of {{MAINT}}.
> * Type {{PATCH}} and type {{MAINT}} should be treated the same for orchestration.
> * If the available services loop has a {{release-version}} then use that to determine if a service should be included in orchestration.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java c5b8269547
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java e2bb27ed5b
>
>
> Diff: https://reviews.apache.org/r/61462/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>