You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/06/30 19:37:29 UTC
Review Request 23173: Adding missing total frameworks metric.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23173/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
total_schedulers from stats.json was never ported to the new metrics endpoint.
Diffs
-----
src/master/master.hpp 5fef35406c2ce2ad11e030aa7752eb691aab5857
src/master/master.cpp 474014b24982449f2f64c2e8d835c25a28cbcbb8
src/tests/master_tests.cpp 4dc28f261bdd460cde59b699c05cf65a326afd4d
Diff: https://reviews.apache.org/r/23173/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 23173: Adding missing total frameworks metric.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23173/#review47010
-----------------------------------------------------------
Patch looks great!
Reviews applied: [23173]
All tests passed.
- Mesos ReviewBot
On June 30, 2014, 5:37 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23173/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 5:37 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> total_schedulers from stats.json was never ported to the new metrics endpoint.
>
>
> Diffs
> -----
>
> src/master/master.hpp 5fef35406c2ce2ad11e030aa7752eb691aab5857
> src/master/master.cpp 474014b24982449f2f64c2e8d835c25a28cbcbb8
> src/tests/master_tests.cpp 4dc28f261bdd460cde59b699c05cf65a326afd4d
>
> Diff: https://reviews.apache.org/r/23173/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 23173: Adding missing total frameworks metric.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23173/#review47528
-----------------------------------------------------------
Hm, do we even need this? In retrospect, "total" seems a bit unintuitive: is it the total number of known frameworks that have not completed? Would it include completed frameworks? Seems like we would want to expose these other metrics before a total makes sense, right? (I noticed there's no total for slaves yet).
- Ben Mahler
On June 30, 2014, 5:37 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23173/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 5:37 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> total_schedulers from stats.json was never ported to the new metrics endpoint.
>
>
> Diffs
> -----
>
> src/master/master.hpp 5fef35406c2ce2ad11e030aa7752eb691aab5857
> src/master/master.cpp 474014b24982449f2f64c2e8d835c25a28cbcbb8
> src/tests/master_tests.cpp 4dc28f261bdd460cde59b699c05cf65a326afd4d
>
> Diff: https://reviews.apache.org/r/23173/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>