You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ma...@apache.org on 2013/08/27 17:39:22 UTC

[1/2] spec commit: Add backButton for autobench.html

Updated Branches:
  refs/heads/3.0.x e12609d87 -> daca6cff9


Add backButton for autobench.html

---Show backButton when tests are done
---Since "licensecontents.js" is non-exist, remove the reference  to it


Project: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/commit/daca6cff
Tree: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/tree/daca6cff
Diff: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/diff/daca6cff

Branch: refs/heads/3.0.x
Commit: daca6cff946b283a0c356d0338b6f0dc2a3b8706
Parents: e0a72bd
Author: lmnbeyond <lm...@gmail.com>
Authored: Wed Aug 14 20:04:14 2013 +0800
Committer: Max Woghiren <ma...@gmail.com>
Committed: Tue Aug 27 11:39:02 2013 -0400

----------------------------------------------------------------------
 benchmarks/autobench.html | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/blob/daca6cff/benchmarks/autobench.html
----------------------------------------------------------------------
diff --git a/benchmarks/autobench.html b/benchmarks/autobench.html
index 445a46d..1a909fb 100644
--- a/benchmarks/autobench.html
+++ b/benchmarks/autobench.html
@@ -27,7 +27,6 @@
     <link rel="stylesheet" href="../master.css" type="text/css" media="screen" title="no title" charset="utf-8">
     <script type="text/javascript" charset="utf-8" src="../cordova-incl.js"></script>      
     <script type="text/javascript" charset="utf-8" src="uubench.js"></script>
-    <script type="text/javascript" charset="utf-8" src="licensecontents.js"></script>
 <script>
     var exec = cordova.require('cordova/exec');
     var temp, pers, LICENSE_CONTENTS;
@@ -62,6 +61,7 @@
         min: 2000, // each benchmark should run for at least 2000ms
         done:function() { 
             $('loading').innerHTML = "Benchmarks complete.";
+            $('backBtn').style.display="block";
         }
     });
     var results = {};
@@ -176,7 +176,7 @@ function bench() {
 </script>
 
   </head>
-  <body>
+  <body id="stage" class="theme">
     <h1>Auto-Benchmarks</h1>
     <h2 id="loading"></h2>
     <table>
@@ -189,5 +189,6 @@ function bench() {
         <tbody id="table-results">
         </tbody>
     </table>
+    <h2>&nbsp</h2><a href="javascript:" class="backBtn" style="display:none" id='backBtn' onclick="backHome();">Back</a><br>
   </body>
 </html>      


[2/2] spec commit: [CB-4568] Disable pop-up messages when running test "XHR to within-package 11kb asset."

Posted by ma...@apache.org.
[CB-4568] Disable pop-up messages when running test "XHR to within-package 11kb asset."

When fetching a file from the local file system, the result status of
XMLHttpRequest should be compared to 0 for success instead of 200.
This is because the file and ftp schemes do not use HTTP result codes.

FYI:https://developer.mozilla.org/es/docs/XMLHttpRequest/Usar_XMLHttpReq
uest


Project: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/commit/e0a72bdc
Tree: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/tree/e0a72bdc
Diff: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/diff/e0a72bdc

Branch: refs/heads/3.0.x
Commit: e0a72bdc2c0167af85053e3b9d92376b78f0fe8e
Parents: e12609d
Author: lmnbeyond <lm...@gmail.com>
Authored: Wed Aug 14 19:54:21 2013 +0800
Committer: Max Woghiren <ma...@gmail.com>
Committed: Tue Aug 27 11:39:02 2013 -0400

----------------------------------------------------------------------
 benchmarks/autobench.html | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/blob/e0a72bdc/benchmarks/autobench.html
----------------------------------------------------------------------
diff --git a/benchmarks/autobench.html b/benchmarks/autobench.html
index 9104f05..445a46d 100644
--- a/benchmarks/autobench.html
+++ b/benchmarks/autobench.html
@@ -127,7 +127,8 @@ function bench() {
         xhr.open("GET", "../LICENSE", true);
         xhr.onreadystatechange = function() {
             if (xhr.readyState == 4) {
-                if (xhr.status == 200) {
+                // The result status is being compared to 0 for success instead of 200. This is because the file and ftp schemes do not use HTTP result codes.
+                if (xhr.status == 0 && xhr.responseText.length > 0) {
                     next();
                 } else {
                     alert('There was a problem during XHR file read!');