You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/01/16 16:36:54 UTC

[GitHub] tysonnorris commented on issue #4141: Use Stricter Retry Logic in ApacheBlockingContainerClient

tysonnorris commented on issue #4141: Use Stricter Retry Logic in ApacheBlockingContainerClient
URL: https://github.com/apache/incubator-openwhisk/pull/4141#issuecomment-454847641
 
 
   Is there any reason not to do some form of health checking *before* any http calls (/init and /run)? e.g. one thing I did in the MesosContainerFactory is to use a tcp healthcheck (the mesos facility), so that the container is not returned until it has a port open, so there is never a retry for /init or /run. This obviously makes container start take longer, but I'm not sure it is ever longer than having /init tolerate failures and retries etc. 
   If that sounds appealing, it would be a change to `Container.create()` (wait/retry for port opening)  and removing retries (right?) from `Container.initialize()`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services