[GitHub] [pinot] deemoliu commented on a diff in pull request #10927: [POC] improve disk read for partial upsert handler

["deemoliu (via GitHub)" <gi...@apache.org>]

deemoliu commented on code in PR #10927:
URL: https://github.com/apache/pinot/pull/10927#discussion_r1237805324


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##########
@@ -219,6 +221,10 @@ protected void doAddRecord(MutableSegment segment, RecordInfo recordInfo) {
   @Override
   protected GenericRow doUpdateRecord(GenericRow record, RecordInfo recordInfo) {
     assert _partialUpsertHandler != null;
+    // For Overwrite merger, it respects the incoming values unless it's null. We can use this to optimize disk read.
+    if (UpsertConfig.Strategy.OVERWRITE.equals(_partialUpsertHandler.getDefaultPartialUpsertMerger())) {

Review Comment:
   good catch, thanks! I though the defaultMerger in upsertHandler is a enum. Let me update this part.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org