[jira] Commented: (MYFACES-2434) dummy request/response classes for system event listeners will break with Servlet 3.0

["Michael Kurz (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784383#action_12784383 ] 

Michael Kurz commented on MYFACES-2434:
---------------------------------------

There is a bug in the new code. I get a NullPointerException on starting my app because of this code in AbstractFacesInitializer:

private void dispatchInitDestroyEvent(Object servletContext, Class eventClass) {
  ApplicationFactory appFac = (ApplicationFactory) FactoryFinder.getFactory(FactoryFinder.APPLICATION_FACTORY);
  FacesContext fc = null;

  fc = FacesContext.getCurrentInstance();
  ExternalContext ec = fc.getExternalContext();
        
  if (fc == null) {
    ...

In my case fc is null!

> dummy request/response classes for system event listeners will break with Servlet 3.0
> -------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2434
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2434
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Michael Concini
>            Assignee: Michael Concini
>             Fix For: 2.0.0-alpha-2
>
>
> Currently the _SystemEventServletRequest and _SystemEventServletResponse classes implement ServletRequest and ServletResponse directly.   There are several new methods that must be implemented in the servlet 3.0 updates of those interfaces.  
> This can be resolved by changing them to extend ServletRequestWrapper and ServletResponseWrapper instead of implementing directly.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.