You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Radu Cotescu <ra...@apache.org> on 2017/02/27 11:17:37 UTC
[VOTE] Release Apache Sling Scripting HTL Compiler 1.0.8, Apache
Sling Scripting HTL Engine 1.0.32
Hi,
We solved 2 issues in these releases:
https://issues.apache.org/jira/browse/SLING/fixforversion/12339164
https://issues.apache.org/jira/browse/SLING/fixforversion/12339176
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1646/
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
Usage:
sh check_staged_release.sh 1646 /tmp/sling-staging
Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...
This majority vote is open for at least 72 hours.
Cheers,
Radu
Re: [VOTE] Release Apache Sling Scripting HTL Compiler 1.0.8, Apache
Sling Scripting HTL Engine 1.0.32
Posted by Radu Cotescu <ra...@apache.org>.
Typo. Yes, we fixed 3 issues. Sorry for that.
On Mon, 27 Feb 2017 at 13:13 Stefan Seifert <ss...@pro-vision.de> wrote:
> +1
>
> stefan
>
> p.s. i count 3 issues, not 2.
>
>
> >-----Original Message-----
> >From: Radu Cotescu [mailto:radu@apache.org]
> >Sent: Monday, February 27, 2017 12:18 PM
> >To: Sling Dev
> >Subject: [VOTE] Release Apache Sling Scripting HTL Compiler 1.0.8, Apache
> >Sling Scripting HTL Engine 1.0.32
> >
> >Hi,
> >
> >We solved 2 issues in these releases:
> >https://issues.apache.org/jira/browse/SLING/fixforversion/12339164
> >https://issues.apache.org/jira/browse/SLING/fixforversion/12339176
> >
> >Staging repository:
> >https://repository.apache.org/content/repositories/orgapachesling-1646/
> >
> >You can use this UNIX script to download the release and verify the
> >signatures:
> >http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> >
> >Usage:
> >sh check_staged_release.sh 1646 /tmp/sling-staging
> >
> >Please vote to approve this release:
> >
> > [ ] +1 Approve the release
> > [ ] 0 Don't care
> > [ ] -1 Don't release, because ...
> >
> >This majority vote is open for at least 72 hours.
> >
> >Cheers,
> >Radu
>
RE: [VOTE] Release Apache Sling Scripting HTL Compiler 1.0.8, Apache
Sling Scripting HTL Engine 1.0.32
Posted by Stefan Seifert <ss...@pro-vision.de>.
+1
stefan
p.s. i count 3 issues, not 2.
>-----Original Message-----
>From: Radu Cotescu [mailto:radu@apache.org]
>Sent: Monday, February 27, 2017 12:18 PM
>To: Sling Dev
>Subject: [VOTE] Release Apache Sling Scripting HTL Compiler 1.0.8, Apache
>Sling Scripting HTL Engine 1.0.32
>
>Hi,
>
>We solved 2 issues in these releases:
>https://issues.apache.org/jira/browse/SLING/fixforversion/12339164
>https://issues.apache.org/jira/browse/SLING/fixforversion/12339176
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-1646/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
>Usage:
>sh check_staged_release.sh 1646 /tmp/sling-staging
>
>Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
>This majority vote is open for at least 72 hours.
>
>Cheers,
>Radu
Re: [VOTE] Release Apache Sling Scripting HTL Compiler 1.0.8, Apache
Sling Scripting HTL Engine 1.0.32
Posted by Daniel Klco <da...@gmail.com>.
+1 -- checked signature and build
On Mon, Feb 27, 2017 at 8:27 AM, Robert Munteanu <ro...@apache.org> wrote:
> On Mon, 2017-02-27 at 11:17 +0000, Radu Cotescu wrote:
> > Please vote to approve this release:
>
> +1
>
> Robert
Re: [VOTE] Release Apache Sling Scripting HTL Compiler 1.0.8,
Apache Sling Scripting HTL Engine 1.0.32
Posted by Robert Munteanu <ro...@apache.org>.
On Mon, 2017-02-27 at 11:17 +0000, Radu Cotescu wrote:
> Please vote to approve this release:
+1
Robert
Re: [VOTE] Release Apache Sling Scripting HTL Compiler 1.0.8, Apache
Sling Scripting HTL Engine 1.0.32
Posted by Radu Cotescu <ra...@apache.org>.
Then let's fix this in trunk, given the fact that we've released several
versions of the engine (1.0.0 - 1.0.18) until now with antlr embedded.
Thanks,
Radu
On Mon, 27 Feb 2017 at 17:05 Karl Pauls <ka...@gmail.com> wrote:
> That said, if you fix it in trunk and get the majority of the votes I
> suppose it isn't the end of the world as there are already releases of
> the binary with this issue.
>
Re: [VOTE] Release Apache Sling Scripting HTL Compiler 1.0.8, Apache
Sling Scripting HTL Engine 1.0.32
Posted by Karl Pauls <ka...@gmail.com>.
Well, I personally think you'd be better of recutting the release.
After all, release votes are pretty much for the purpose of making
sure there are no legal issues with the release and not having the
proper licenses in place isn't good.
That said, if you fix it in trunk and get the majority of the votes I
suppose it isn't the end of the world as there are already releases of
the binary with this issue.
In other words, up to you (and maybe on how much work is involved in
recutting the release) but I would just declare this vote to continue
for the Engine only (so you don't have to recut that one) and start a
new one for the compiler.
regards,
Karl
On Mon, Feb 27, 2017 at 4:19 PM, Radu Cotescu <ra...@apache.org> wrote:
> Hi Karl,
>
> I guess we should. Do you consider this a release blocker or can I just add
> them into a separate commit?
>
> Cheers,
> Radu
>
> On Mon, 27 Feb 2017 at 15:52 Karl Pauls <ka...@gmail.com> wrote:
>
>> [...]
>> Shouldn't they be added to the LICENSE file?
>>
--
Karl Pauls
karlpauls@gmail.com
Re: [VOTE] Release Apache Sling Scripting HTL Compiler 1.0.8, Apache
Sling Scripting HTL Engine 1.0.32
Posted by Radu Cotescu <ra...@apache.org>.
Hi Karl,
I guess we should. Do you consider this a release blocker or can I just add
them into a separate commit?
Cheers,
Radu
On Mon, 27 Feb 2017 at 15:52 Karl Pauls <ka...@gmail.com> wrote:
> [...]
> Shouldn't they be added to the LICENSE file?
>
Re: [VOTE] Release Apache Sling Scripting HTL Compiler 1.0.8, Apache
Sling Scripting HTL Engine 1.0.32
Posted by Karl Pauls <ka...@gmail.com>.
The HTL Compiler binary embeds antlr4-runtime-4.1.jar and
org.abego.treelayout.core-1.0.1.jar.
Both are under BSD license. While they are mentioned in the
DEPENDENCIES I couldn't find the actual licenses in the LICENSE file.
Shouldn't they be added to the LICENSE file?
regards,
Karl
On Mon, Feb 27, 2017 at 12:17 PM, Radu Cotescu <ra...@apache.org> wrote:
> Hi,
>
> We solved 2 issues in these releases:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12339164
> https://issues.apache.org/jira/browse/SLING/fixforversion/12339176
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1646/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1646 /tmp/sling-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Cheers,
> Radu
--
Karl Pauls
karlpauls@gmail.com