[GitHub] [hadoop] alkis commented on pull request #5685: HADOOP-18748 Optimize Configuration.handleDeprecation

["alkis (via GitHub)" <gi...@apache.org>]

alkis commented on PR #5685:
URL: https://github.com/apache/hadoop/pull/5685#issuecomment-1558976068

   > you know, if we could speed up the basic .get() it can only be good. at the same time, this is such a broadly used piece of code, we are scared of doing anything risky to it.
   > 
   > what can we do in terms of testing that all this is good? I'm thinking of concurrency as well as everything else?
   
   That's a good point. I have specifically avoided a larger rewrite to reduce the risks in breaking the implementation. `Configuration` is used pervasively in most tests and there are specific tests for its basic and deprecated keys usages. In terms of concurrency I also avoided changing it to avoid risks - the concurrency is the same as before.
   
   Can you advice on how to apply this change in other branches as well such that older versions can receive the benefits?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org