Problem in base64 encoding, or in svndiff generation?

[Karl Fogel <kf...@galois.collab.net>]

In a commit just now, I wrote:

   > Note: this change breaks "make check", because the final update in 
   > client/tests/t2 fails, apparently due to some ascii nulls in the XML 
   > file resulting from the second commit (run "make check" in 
   > subversion/client/, then look at
   > subversion/client/tests/commit-2.xml, line 51).  
   > Am committing anyway for the sake of reproduction, but will commit 
   > another change immediately to restore "make check"'s success.

Then my next commit fixed "make check", but you can still reproduce
the problem and get a client/tests/commit-2.xml that contains ascii
nulls.  Just run "make check"; it will succeed, because it doesn't try
to apply the bogus xml delta.

Greg H, I expect you'd be able to find the problem very quickly...

-K


2000-11-07 17:38   Karl Fogel <kf...@collab.net>

	* subversion/: client/tests/svn-test.sh (1.14),
	libsvn_wc/get_editor.c (1.119), libsvn_wc/log.c (1.50):

	Preserve local mods by patching: 
	
	* libsvn_client/tests/svn-test.sh: make more changes in the updated 
	tree t2, commit them.  
	
	* libsvn_wc/get_editor.c (close_file): if working file present,
	update by patching.  
	
	* libsvn_wc/log.c (start_handler): implement SVN_WC__LOG_RUN_CMD.  
	(run_cmd_under_directory): removed, unnecessary right now.  
	Note: this change breaks "make check", because the final update in 
	client/tests/t2 fails, apparently due to some ascii nulls in the XML 
	file resulting from the second commit (run "make check" in 
	subversion/client/, then look at
	subversion/client/tests/commit-2.xml, line 51).  
	Am committing anyway for the sake of reproduction, but will commit 
	another change immediately to restore "make check"'s success.