[GitHub] [ozone] avijayanhwx commented on a change in pull request #2538: HDDS-5619. Ozone data corruption issue on follower node.

[GitBox <gi...@apache.org>]

avijayanhwx commented on a change in pull request #2538:
URL: https://github.com/apache/ozone/pull/2538#discussion_r689883026



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java
##########
@@ -595,6 +603,12 @@ ContainerCommandResponseProto handleReadChunk(
 
       data = chunkManager.readChunk(kvContainer, blockID, chunkInfo,
           dispatcherContext);
+      // Validate data only if the read chunk issued as a result of
+      // ratis call internally. For client reads, validation happens
+      // on the client
+      if (dispatcherContext.isReadFromTmpFile()) {
+        validateChunkData(data, chunkInfo);

Review comment:
       Why do we have checksum verification in chunkManager.readChunk as well as here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org