You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/07 03:02:39 UTC

[GitHub] [spark] linhongliu-db opened a new pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

linhongliu-db opened a new pull request #30637:
URL: https://github.com/apache/spark/pull/30637


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   The analyzer rule `PreprocessTableCreation` will preprocess table creation related logical plan. But for
   CTAS, if the sub-query can't be resolved, preprocess it will cause "Invalid call to toAttribute on unresolved
   object" (instead of a user-friendly error msg: "table or view not found").
   This PR fixes this wrongly preprocess for CTAS using V2 catalog.
   
   ### Why are the changes needed?
   bug fix
   
   
   ### Does this PR introduce _any_ user-facing change?
   The error message for CTAS with a non-exists table changed from:
   `UnresolvedException: Invalid call to toAttribute on unresolved object, tree: xxx` to
   `AnalysisException: Table or view not found: xxx`
   
   
   ### How was this patch tested?
   added test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739829642


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36944/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] linhongliu-db commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
linhongliu-db commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739887060


   cc @cloud-fan 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] linhongliu-db commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
linhongliu-db commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739740497


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739675066


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36918/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739811948


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36944/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739733537


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132318/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739890144


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132342/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739742191


   **[Test build #132342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132342/testReport)** for PR 30637 at commit [`c14185e`](https://github.com/apache/spark/commit/c14185e0d7ba3c73415aef8e2653641c1b33f0ed).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739793138


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36944/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739642602


   **[Test build #132318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132318/testReport)** for PR 30637 at commit [`c14185e`](https://github.com/apache/spark/commit/c14185e0d7ba3c73415aef8e2653641c1b33f0ed).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan closed pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30637:
URL: https://github.com/apache/spark/pull/30637


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739890144


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132342/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739917110


   @linhongliu-db can you open a PR for 3.0?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] linhongliu-db closed pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
linhongliu-db closed pull request #30637:
URL: https://github.com/apache/spark/pull/30637


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739829642


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36944/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739916889


   thanks, merging to master/3.1!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739657864


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36918/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739668199


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36918/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739732931


   **[Test build #132318 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132318/testReport)** for PR 30637 at commit [`c14185e`](https://github.com/apache/spark/commit/c14185e0d7ba3c73415aef8e2653641c1b33f0ed).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739733537


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132318/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739675066


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36918/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739742191


   **[Test build #132342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132342/testReport)** for PR 30637 at commit [`c14185e`](https://github.com/apache/spark/commit/c14185e0d7ba3c73415aef8e2653641c1b33f0ed).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] linhongliu-db commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
linhongliu-db commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739634479


   This is a re-open PR of https://github.com/apache/spark/pull/29507. The previous is closed as a stale PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739885983


   **[Test build #132342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132342/testReport)** for PR 30637 at commit [`c14185e`](https://github.com/apache/spark/commit/c14185e0d7ba3c73415aef8e2653641c1b33f0ed).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #30637: [SPARK-32680][SQL] Don't Preprocess V2 CTAS with Unresolved Query

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30637:
URL: https://github.com/apache/spark/pull/30637#issuecomment-739642602


   **[Test build #132318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132318/testReport)** for PR 30637 at commit [`c14185e`](https://github.com/apache/spark/commit/c14185e0d7ba3c73415aef8e2653641c1b33f0ed).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org