You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "xli1996 (via GitHub)" <gi...@apache.org> on 2026/01/22 06:52:26 UTC
[I] [Tech Debt] Align default value for python and java openai chatmodel [flink-agents]
xli1996 opened a new issue, #464:
URL: https://github.com/apache/flink-agents/issues/464
### Search before asking
- [x] I searched in the [issues](https://github.com/apache/flink-agents/issues) and found nothing similar.
### Description
I notice that java and python openai chatmodel has some inconsistency default value for parameters. They should have same default parameters so make less confusion.
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Tech Debt] Align default value for python and java openai chatmodel [flink-agents]
Posted by "wenjin272 (via GitHub)" <gi...@apache.org>.
wenjin272 closed issue #464: [Tech Debt] Align default value for python and java openai chatmodel
URL: https://github.com/apache/flink-agents/issues/464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Tech Debt] Align default value for python and java openai chatmodel [flink-agents]
Posted by "sahithreddy05 (via GitHub)" <gi...@apache.org>.
sahithreddy05 commented on issue #464:
URL: https://github.com/apache/flink-agents/issues/464#issuecomment-4912243222
Hi, I'd like to work on this one.
I looked at main and the Setup defaults are actually already the same on both sides (gpt-3.5-turbo, temperature 0.1, etc). The mismatch is in the connection: python defaults timeout to 60s and max_retries to 3, but the java connections only set these when the user passes them explicitly, so otherwise you just get whatever the openai-java SDK defaults to. The Azure connection has the same problem.
My plan is to add a small shared class with the two defaults (60 / 3, same as python) and use it from both connections, plus tests. I have it working locally already, it's a pretty small diff.
Two questions:
1. Is it ok to fix the Azure connection in the same PR since it's the same bug in the same module, or do you want a separate issue for that?
2. Python raises on negative values but the java side currently documents that out-of-range values are ignored. I kept the ignore behavior to not change anything, but can switch it to raising if you'd rather have them fully consistent.
Also noticed timeout is a float in python but read as Integer in java, so fractional timeouts don't work on the java side. Can file that separately if useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Tech Debt] Align default value for python and java openai chatmodel [flink-agents]
Posted by "wenjin272 (via GitHub)" <gi...@apache.org>.
wenjin272 commented on issue #464:
URL: https://github.com/apache/flink-agents/issues/464#issuecomment-4921266709
Hi, @sahithreddy05, thanks for your interest in working on this. Since @rob-9 has already submitted a PR, it would be great if you could take a look at the ongoing work there first. If you notice anything missing or have ideas for improvement, please feel free to comment on the PR or help review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org