You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/06 09:39:35 UTC

[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19554: feat(forecast): Forecasting plugin system

zhaoyongjie commented on code in PR #19554:
URL: https://github.com/apache/superset/pull/19554#discussion_r843724894


##########
tests/unit_tests/pandas_postprocessing/test_aggregate.py:
##########
@@ -14,12 +14,15 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-from superset.utils.pandas_postprocessing import aggregate
+from flask.ctx import AppContext
+
 from tests.unit_tests.fixtures.dataframes import categories_df
 from tests.unit_tests.pandas_postprocessing.utils import series_to_list
 
 
-def test_aggregate():
+def test_aggregate(app_context: AppContext) -> None:
+    from superset.utils.pandas_postprocessing import aggregate
+

Review Comment:
   The `Flask Application Context` seems that does not relate to `Operators`. We can add an integration test for `Operators` and `QueryObject`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org