You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2017/12/20 23:58:24 UTC
[GitHub] activemq-artemis pull request #1736: ARTEMIS-1569 - Queue - User Enhancement
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1736
ARTEMIS-1569 - Queue - User Enhancement
Expose User associated with creating Queue on JMX QueueControl (as attribute)
Allow setting of the user to associate with creating the queue when configured in broker.xml (before only if created over wire is it possible to set the user)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1569
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1736.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1736
----
commit 7815c3e10d17cff49864ee328f4af64151309857
Author: Michael André Pearce <mi...@...>
Date: 2017-12-20T23:45:54Z
ARTEMIS-1569 - Queue - User Enhancement
Expose User associated with creating Queue on JMX QueueControl (as attribute)
Allow setting of the user to associate with creating the queue when configured in broker.xml (before only if created over wire is it possible to set the user)
----
---
[GitHub] activemq-artemis pull request #1736: ARTEMIS-1569 - Queue - User Enhancement
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1736
---
[GitHub] activemq-artemis pull request #1736: ARTEMIS-1569 - Queue - User Enhancement
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1736#discussion_r158307133
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
@@ -2508,7 +2508,7 @@ private void deployQueuesFromListCoreQueueConfiguration(List<CoreQueueConfigurat
// if the address::queue doesn't exist then create it
try {
createQueue(SimpleString.toSimpleString(config.getAddress()), config.getRoutingType(),
- queueName, SimpleString.toSimpleString(config.getFilterString()),null,
+ queueName, SimpleString.toSimpleString(config.getFilterString()), SimpleString.toSimpleString(config.getUser()),
--- End diff --
Its good, we now have an extra test now :) who doesn't like one of those :)
Ok i will merge, cheers.
---
[GitHub] activemq-artemis pull request #1736: ARTEMIS-1569 - Queue - User Enhancement
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1736#discussion_r158302926
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
@@ -2508,7 +2508,7 @@ private void deployQueuesFromListCoreQueueConfiguration(List<CoreQueueConfigurat
// if the address::queue doesn't exist then create it
try {
createQueue(SimpleString.toSimpleString(config.getAddress()), config.getRoutingType(),
- queueName, SimpleString.toSimpleString(config.getFilterString()),null,
+ queueName, SimpleString.toSimpleString(config.getFilterString()), SimpleString.toSimpleString(config.getUser()),
--- End diff --
Cool. I have bad memory. :)
+1 on merging this. I’m away from computer. But feel free to merge it yourself if you feel like.
Will merge when I get back to a computer.
---
[GitHub] activemq-artemis issue #1736: ARTEMIS-1569 - Queue - User Enhancement
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1736
PR build failed due to https://github.com/apache/activemq-artemis/pull/1683 - unrelated to this change.
---
[GitHub] activemq-artemis issue #1736: ARTEMIS-1569 - Queue - User Enhancement
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1736
notice I have sent a later fix to the testsuite
---
[GitHub] activemq-artemis pull request #1736: ARTEMIS-1569 - Queue - User Enhancement
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1736#discussion_r158294873
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
@@ -2508,7 +2508,7 @@ private void deployQueuesFromListCoreQueueConfiguration(List<CoreQueueConfigurat
// if the address::queue doesn't exist then create it
try {
createQueue(SimpleString.toSimpleString(config.getAddress()), config.getRoutingType(),
- queueName, SimpleString.toSimpleString(config.getFilterString()),null,
+ queueName, SimpleString.toSimpleString(config.getFilterString()), SimpleString.toSimpleString(config.getUser()),
--- End diff --
@clebertsuconic it does, it was existing functionality internally, just not set-able from broker.xml I have added a test just to prove that it is persisted and survives restart
---
[GitHub] activemq-artemis pull request #1736: ARTEMIS-1569 - Queue - User Enhancement
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1736#discussion_r158220580
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
@@ -2508,7 +2508,7 @@ private void deployQueuesFromListCoreQueueConfiguration(List<CoreQueueConfigurat
// if the address::queue doesn't exist then create it
try {
createQueue(SimpleString.toSimpleString(config.getAddress()), config.getRoutingType(),
- queueName, SimpleString.toSimpleString(config.getFilterString()),null,
+ queueName, SimpleString.toSimpleString(config.getFilterString()), SimpleString.toSimpleString(config.getUser()),
--- End diff --
I don't think this is being persisted though
---