You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/04/22 10:44:11 UTC

[GitHub] [drill] wojustme opened a new pull request, #2522: [BUG] Fix REPLACE's IndexOutOfBoundsException, if text's length is more than previously applied

wojustme opened a new pull request, #2522:
URL: https://github.com/apache/drill/pull/2522

   
   
   # [DRILL-8194](https://issues.apache.org/jira/browse/DRILL-8194): Function of REPLACE throws IndexOutOfBoundsException, if text's length is more than previously applied
   
   (Please replace `PR Title` with actual PR Title)
   
   ## Description
   
   Add code to check buffer's capacity with text's length.
   We realloc buffer, if actual length is more than previously applied.
   
   ## Documentation
   NA
   
   ## Testing
   Add test case: org.apache.drill.exec.expr.fn.impl.TestStringFunctions#testReplaceOutBuffer
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [drill] wojustme commented on pull request #2522: DRILL-8194: Fix the function of REPLACE throws IndexOutOfBoundsException, if text's length is more than previously applied

Posted by GitBox <gi...@apache.org>.
wojustme commented on PR #2522:
URL: https://github.com/apache/drill/pull/2522#issuecomment-1107688617

   @luocooong Thanks for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [drill] cgivre commented on pull request #2522: DRILL-8194: Fix the function of REPLACE throws IndexOutOfBoundsException, if text's length is more than previously applied

Posted by GitBox <gi...@apache.org>.
cgivre commented on PR #2522:
URL: https://github.com/apache/drill/pull/2522#issuecomment-1107691060

   @wojustme Thanks for your first contribution and good bug fix!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [drill] cgivre merged pull request #2522: DRILL-8194: Fix the function of REPLACE throws IndexOutOfBoundsException, if text's length is more than previously applied

Posted by GitBox <gi...@apache.org>.
cgivre merged PR #2522:
URL: https://github.com/apache/drill/pull/2522


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org