You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@yunikorn.apache.org by "Wilfred Spiegelenburg (Jira)" <ji...@apache.org> on 2021/12/21 06:59:00 UTC

[jira] [Resolved] (YUNIKORN-981) Cleanup comments and logging in queue code

     [ https://issues.apache.org/jira/browse/YUNIKORN-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wilfred Spiegelenburg resolved YUNIKORN-981.
--------------------------------------------
    Fix Version/s: 1.0.0
       Resolution: Fixed

queue code cleaned up 

> Cleanup comments and logging in queue code
> ------------------------------------------
>
>                 Key: YUNIKORN-981
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-981
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - scheduler
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.0.0
>
>
> The queue code is missing some crucial logging and logs at the wrong level. One case logs an error as many times as the queue hierarchy is deep. This causes one error to be logged multiple times including stack traces. Code changes are limited to logging cleanup.
> In the queue code the comments do not comply with the go best practice for function comments.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org