You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "troizet (via GitHub)" <gi...@apache.org> on 2023/02/12 07:48:00 UTC

[GitHub] [netbeans] troizet opened a new pull request, #5476: PHP: Corrected a typo in the php parser tests

troizet opened a new pull request, #5476:
URL: https://github.com/apache/netbeans/pull/5476

   Corrected a typo in the php parser tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] junichi11 commented on pull request #5476: PHP: Corrected a typo in the php parser tests

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #5476:
URL: https://github.com/apache/netbeans/pull/5476#issuecomment-1427341619

   @mbien OK. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] junichi11 commented on pull request #5476: PHP: Corrected a typo in the php parser tests

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #5476:
URL: https://github.com/apache/netbeans/pull/5476#issuecomment-1427181702

   @mbien Doesn't work tests of php.editor?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #5476: PHP: Corrected a typo in the php parser tests

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5476:
URL: https://github.com/apache/netbeans/pull/5476#issuecomment-1427333652

   > @mbien Doesn't CI run tests of php.editor?
   
   hi @junichi11, the label was added *after* the workflow request was built. Starting a fresh workflow will take new labels into account (restarting will not unfortunately).
   
   This is the main reason we have the "secret" workaround of PR locking/unlocking which is used a trigger for a fresh workflow run (instead of restarting an old run which does not update its label information).
   
   going to do this now and start a fresh workflow run here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] KacerCZ commented on pull request #5476: PHP: Corrected a typo in the php parser tests

Posted by "KacerCZ (via GitHub)" <gi...@apache.org>.
KacerCZ commented on PR #5476:
URL: https://github.com/apache/netbeans/pull/5476#issuecomment-1427001787

   Change looks sane.
   Let's see result of CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] junichi11 merged pull request #5476: PHP: Corrected a typo in the php parser tests

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 merged PR #5476:
URL: https://github.com/apache/netbeans/pull/5476


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #5476: PHP: Corrected a typo in the php parser tests

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5476:
URL: https://github.com/apache/netbeans/pull/5476#issuecomment-1427346075

   @junichi11 thanks for checking that the correct tests run during review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists