You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/29 13:27:34 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #4015: Test benchmarks in CI
andygrove opened a new pull request, #4015:
URL: https://github.com/apache/arrow-datafusion/pull/4015
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
N/A
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I would like to test that the benchmarks are producing the correct results so that we catch regressions.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4015: Add CI check to verify that benchmark queries return the expected results
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4015:
URL: https://github.com/apache/arrow-datafusion/pull/4015#issuecomment-1296271854
Benchmark runs are scheduled for baseline = d391b859c44e1c366eb4da5e8cabd199336f4243 and contender = 66510704369f9eb5a7d973a530148aee890c1191. 66510704369f9eb5a7d973a530148aee890c1191 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f273ae3b14214b32b0c8eea78f1fad9d...5cc83a61a1b3404c80b057abbf713eb3/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/eac1d4a962fb44f98cc01832d0afd0a8...5b79910b34ff4ac3a2ad81e7a8fc12c9/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b88c971d4b394cebbf20ba0e88d874ae...b72e3dc0be7b41e2b3ebb5ed9f355e6f/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/19723e9d87ff4c09a0754b82f92ac541...7b4e626137b74c709ab4382fe338e5aa/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #4015: Add CI check to verify that benchmark queries return the expected results
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #4015:
URL: https://github.com/apache/arrow-datafusion/pull/4015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #4015: Add CI check to verify that benchmark queries return the expected results
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #4015:
URL: https://github.com/apache/arrow-datafusion/pull/4015#discussion_r1008758533
##########
benchmarks/src/bin/tpch.rs:
##########
@@ -829,113 +618,140 @@ mod tests {
Ok(str)
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q1() -> Result<()> {
+ async fn verify_q1() -> Result<()> {
verify_query(1).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q2() -> Result<()> {
+ async fn verify_q2() -> Result<()> {
verify_query(2).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q3() -> Result<()> {
+ async fn verify_q3() -> Result<()> {
verify_query(3).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q4() -> Result<()> {
+ async fn verify_q4() -> Result<()> {
verify_query(4).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q5() -> Result<()> {
+ async fn verify_q5() -> Result<()> {
verify_query(5).await
}
+ #[cfg(feature = "ci")]
+ #[ignore] // TODO produces wrong result
#[tokio::test]
- async fn q6() -> Result<()> {
+ async fn verify_q6() -> Result<()> {
Review Comment:
https://github.com/apache/arrow-datafusion/issues/4024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #4015: Add CI check to verify that benchmark queries return the expected results
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #4015:
URL: https://github.com/apache/arrow-datafusion/pull/4015#discussion_r1008741971
##########
Cargo.toml:
##########
@@ -16,21 +16,24 @@
# under the License.
[workspace]
-members = [
- "datafusion/common",
- "datafusion/core",
- "datafusion/expr",
- "datafusion/jit",
- "datafusion/optimizer",
- "datafusion/physical-expr",
- "datafusion/proto",
- "datafusion/row",
- "datafusion/sql",
- "datafusion-examples",
- "benchmarks",
-]
exclude = ["datafusion-cli"]
+members = ["datafusion/common", "datafusion/core", "datafusion/expr", "datafusion/jit", "datafusion/optimizer", "datafusion/physical-expr", "datafusion/proto", "datafusion/row", "datafusion/sql", "datafusion-examples", "benchmarks",
+]
[profile.release]
codegen-units = 1
lto = true
+
+# the release profile takes a long time to build so we can use this profile during development to save time
+# cargo build --profile release-nonlto
+[profile.release-nonlto]
Review Comment:
The CI workflow uses this profile rather than `release` to try and save some time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #4015: Add CI check to verify that benchmark queries return the expected results
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #4015:
URL: https://github.com/apache/arrow-datafusion/pull/4015#discussion_r1008757702
##########
benchmarks/src/bin/tpch.rs:
##########
@@ -829,113 +618,140 @@ mod tests {
Ok(str)
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q1() -> Result<()> {
+ async fn verify_q1() -> Result<()> {
verify_query(1).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q2() -> Result<()> {
+ async fn verify_q2() -> Result<()> {
verify_query(2).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q3() -> Result<()> {
+ async fn verify_q3() -> Result<()> {
verify_query(3).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q4() -> Result<()> {
+ async fn verify_q4() -> Result<()> {
verify_query(4).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q5() -> Result<()> {
+ async fn verify_q5() -> Result<()> {
verify_query(5).await
}
+ #[cfg(feature = "ci")]
+ #[ignore] // TODO produces wrong result
#[tokio::test]
- async fn q6() -> Result<()> {
+ async fn verify_q6() -> Result<()> {
verify_query(6).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q7() -> Result<()> {
+ async fn verify_q7() -> Result<()> {
verify_query(7).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q8() -> Result<()> {
+ async fn verify_q8() -> Result<()> {
verify_query(8).await
}
+ #[cfg(feature = "ci")]
+ #[ignore] // TODO produces correct result but has rounding error
#[tokio::test]
- async fn q9() -> Result<()> {
+ async fn verify_q9() -> Result<()> {
verify_query(9).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q10() -> Result<()> {
+ async fn verify_q10() -> Result<()> {
verify_query(10).await
}
+ #[cfg(feature = "ci")]
+ #[ignore] // TODO produces wrong number of rows
#[tokio::test]
- async fn q11() -> Result<()> {
+ async fn verify_q11() -> Result<()> {
Review Comment:
fails due to https://github.com/apache/arrow-datafusion/issues/4023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org