You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by eddiewebb <gi...@git.apache.org> on 2016/02/05 19:51:23 UTC
[GitHub] maven-scm pull request: #resolves SCM-817 by encoding password bef...
GitHub user eddiewebb opened a pull request:
https://github.com/apache/maven-scm/pull/44
#resolves SCM-817 by encoding password before replace
This resolves https://issues.apache.org/jira/browse/SCM-817 by encoding the password before trying to match against the pre-encoded URL.
Before this commit any passwords with special characters would print the encoded value.
```
[INFO] Change the default 'git' provider implementation to 'jgit'.
[INFO] fetch url: eddie:secr%24t@https//git.somesite.com/repo.git
[INFO] push url: eddie:secr%24t@https//git.somesite.com/repo.git
```
After this commit all passwords will be masked.
```
[INFO] Change the default 'git' provider implementation to 'jgit'.
[INFO] fetch url: eddie:******@https//git.somesite.com/repo.git
[INFO] push url: eddie:******@https//git.somesite.com/repo.git
```
I could not find any tests related specifically to security or masking, if there are tests I can expand please provide direction!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Libertymutual/maven-scm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-scm/pull/44.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #44
----
commit 3aaad27f41cc2d51759cd895f7c269cb60cf3b35
Author: EDWARD WEBB <ed...@libertymutual.com>
Date: 2016-02-05T17:46:32Z
#resolves SCM-817 by encoding password before replace
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-scm pull request: #resolves SCM-817 by encoding password bef...
Posted by eddiewebb <gi...@git.apache.org>.
Github user eddiewebb commented on the pull request:
https://github.com/apache/maven-scm/pull/44#issuecomment-221606935
@olamy @rodrigc @msperisen - I also submitted https://github.com/apache/maven-scm/pull/45 around the same time for similar issue with native git client.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-scm pull request: #resolves SCM-817 by encoding password bef...
Posted by msperisen <gi...@git.apache.org>.
Github user msperisen commented on the pull request:
https://github.com/apache/maven-scm/pull/44#issuecomment-219951622
great, this solves a big issue we are having!
@olamy, can you comment on the implementation and if/when this could be merged and make it into a release?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-scm pull request: #resolves SCM-817 by encoding password bef...
Posted by rodrigc <gi...@git.apache.org>.
Github user rodrigc commented on the pull request:
https://github.com/apache/maven-scm/pull/44#issuecomment-220794627
@olamy @khmarbaise If you could look at this issue and also do a new release of maven-scm, that would be greatly appreciated. That would also help with the issue that I brought up on the mailing list: http://mail-archives.apache.org/mod_mbox/maven-dev/201605.mbox/%3CCAG%3DrPVf6GP3tgXoaAGdru6bQ_CLONo%2BGQUcLPRWpDmP8KqGM7w%40mail.gmail.com%3E
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-scm pull request: #resolves SCM-817 by encoding password bef...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/maven-scm/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org