You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/02 08:45:24 UTC
[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe split() operator
mjsax commented on a change in pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#discussion_r568413963
##########
File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Branched.scala
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.streams.scala.kstream
+
+import org.apache.kafka.streams.kstream.{Branched => BranchedJ, KStream => KStreamJ}
+
+import scala.jdk.FunctionConverters._
+
+object Branched {
+
+ /**
+ * Create an instance of `Branched` with provided branch name suffix.
+ *
+ * @param name the branch name suffix to be used (see [[BranchedKStream]] description for details)
+ * @tparam K key type
+ * @tparam V value type
+ * @return a new instance of `Branched`
+ */
+ def as[K, V](name: String): BranchedJ[K, V] =
+ BranchedJ.as[K, V](name)
+
+ /**
+ * Create an instance of `Branched` with provided chain function and branch name suffix.
+ *
+ * @param chain A function that will be applied to the branch. If the provided function returns
+ * `null`, its result is ignored, otherwise it is added to the Map returned
+ * by [[BranchedKStream.defaultBranch]] or [[BranchedKStream.noDefaultBranch]] (see
+ * [[BranchedKStream]] description for details).
+ * @param name the branch name suffix to be used. If `null`, a default branch name suffix will be generated
+ * (see [[BranchedKStream]] description for details)
+ * @tparam K key type
+ * @tparam V value type
+ * @return a new instance of `Branched`
+ * @see `org.apache.kafka.streams.kstream.Branched#withFunction(java.util.function.Function, java.lang.String)`
+ */
+ def withFunction[K, V](chain: KStream[K, V] => KStream[K, V], name: String = null): BranchedJ[K, V] =
+ BranchedJ.withFunction({ s: KStreamJ[K, V] =>
+ chain.apply(new KStream[K, V](s)).inner
+ }.asJava, name)
Review comment:
Instead of using `asJava` we can do those three lines as:
```
BranchedJ.withFunction((f: KStreamJ[K, V]) => chain.apply(new KStream[K, V](f)).inner, name)
```
##########
File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Branched.scala
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.streams.scala.kstream
+
+import org.apache.kafka.streams.kstream.{Branched => BranchedJ, KStream => KStreamJ}
+
+import scala.jdk.FunctionConverters._
Review comment:
Based on you main comment, you are right, that those `FunctionConverters ` are only available, in Scala 2.13, but the code must compile with Scala 2.12.
Thus we must remove this import and do the `Function/Consumer` conversion below manually (cf below).
##########
File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Branched.scala
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.streams.scala.kstream
+
+import org.apache.kafka.streams.kstream.{Branched => BranchedJ, KStream => KStreamJ}
+
+import scala.jdk.FunctionConverters._
+
+object Branched {
+
+ /**
+ * Create an instance of `Branched` with provided branch name suffix.
+ *
+ * @param name the branch name suffix to be used (see [[BranchedKStream]] description for details)
+ * @tparam K key type
+ * @tparam V value type
+ * @return a new instance of `Branched`
+ */
+ def as[K, V](name: String): BranchedJ[K, V] =
+ BranchedJ.as[K, V](name)
+
+ /**
+ * Create an instance of `Branched` with provided chain function and branch name suffix.
+ *
+ * @param chain A function that will be applied to the branch. If the provided function returns
+ * `null`, its result is ignored, otherwise it is added to the Map returned
+ * by [[BranchedKStream.defaultBranch]] or [[BranchedKStream.noDefaultBranch]] (see
+ * [[BranchedKStream]] description for details).
+ * @param name the branch name suffix to be used. If `null`, a default branch name suffix will be generated
+ * (see [[BranchedKStream]] description for details)
+ * @tparam K key type
+ * @tparam V value type
+ * @return a new instance of `Branched`
+ * @see `org.apache.kafka.streams.kstream.Branched#withFunction(java.util.function.Function, java.lang.String)`
+ */
+ def withFunction[K, V](chain: KStream[K, V] => KStream[K, V], name: String = null): BranchedJ[K, V] =
+ BranchedJ.withFunction({ s: KStreamJ[K, V] =>
+ chain.apply(new KStream[K, V](s)).inner
+ }.asJava, name)
+
+ /**
+ * Create an instance of `Branched` with provided chain consumer and branch name suffix.
+ *
+ * @param chain A consumer to which the branch will be sent. If a non-null consumer is provided here,
+ * the respective branch will not be added to the resulting Map returned
+ * by [[BranchedKStream.defaultBranch]] or [[BranchedKStream.noDefaultBranch]] (see
+ * [[BranchedKStream]] description for details).
+ * @param name the branch name suffix to be used. If `null`, a default branch name suffix will be generated
+ * (see [[BranchedKStream]] description for details)
+ * @tparam K key type
+ * @tparam V value type
+ * @return a new instance of `Branched`
+ * @see `org.apache.kafka.streams.kstream.Branched#withConsumer(java.util.function.Consumer, java.lang.String)`
+ */
+ def withConsumer[K, V](chain: KStream[K, V] => Unit, name: String = null): BranchedJ[K, V] =
+ BranchedJ.withConsumer({ s: KStreamJ[K, V] =>
+ chain.apply(new KStream[K, V](s))
+ }.asJava, name)
Review comment:
Instead of using `asJava` we can do those three lines as:
```
BranchedJ.withConsumer((c: KStreamJ[K, V]) => chain.apply(new KStream[K, V](c)), name)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org