You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2016/09/01 19:44:56 UTC
[Impala-CR] IMPALA-3090: always log memory limit errors
Hello Internal Jenkins, Tim Armstrong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4245
to review the following change.
Change subject: IMPALA-3090: always log memory limit errors
......................................................................
IMPALA-3090: always log memory limit errors
Consistently log memory limit errors so that the error message contains
a dump of the query memory trackers at the time that the memory limit
was hit (instead of after the fact when the query is already partially
cleaned up).
Testing:
Exhaustive build passed. Ran local stress test for a bit.
Change-Id: If5ec5572b0e26898da352b7e6b11eb01c6edb2e5
Reviewed-on: http://gerrit.cloudera.org:8080/4049
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit 7eb30309f3847f416f204bd5f7d6925102e94b67)
---
M be/src/exec/analytic-eval-node.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/runtime/buffered-block-mgr.cc
M be/src/runtime/mem-tracker.h
M be/src/runtime/plan-fragment-executor.cc
M be/src/runtime/row-batch.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/sorter.cc
8 files changed, 38 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/45/4245/1
--
To view, visit http://gerrit.cloudera.org:8080/4245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5ec5572b0e26898da352b7e6b11eb01c6edb2e5
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
[Impala-CR] IMPALA-3090: always log memory limit errors
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change.
Change subject: IMPALA-3090: always log memory limit errors
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/4245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: If5ec5572b0e26898da352b7e6b11eb01c6edb2e5
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>