You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/09/13 16:44:59 UTC
Review Request 51849: GEODE-17: consolidate GeodeSecurityUtil and
IntegratedSecurityService
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51849/
-----------------------------------------------------------
Review request for geode, Kevin Duling and Kirk Lund.
Repository: geode
Description
-------
GEODE-17: consolidate GeodeSecurityUtil and IntegratedSecurityService
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java e94ef353889d7ea051ec4975aba74aab5fc00bd5
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java 260121dcc0b08e37869169931ee380a3d248fa3e
geode-core/src/main/java/com/gemstone/gemfire/internal/security/IntegratedSecurityService.java d294859a2652f01621ddd1b4e259e78c1f4cf16f
geode-core/src/main/java/com/gemstone/gemfire/internal/security/SecurityService.java c97575141e93aca71b14e2c63937f69174589356
geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java ad27ec33e0f3f147f410e194658569e0c11b0e8d
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java f3c771f308e9b492a223a110ec130c9f07278dfb
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/domain/DataCommandRequest.java 76582c329aad8d3d8055ee87ab9ea39364f7cdc4
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java 27082424e5353692d0a51fe41dd0cbc99fbecd0f
geode-core/src/main/java/org/apache/geode/security/PostProcessor.java 3c50ecc1e526f43a6eb861285fa17cf1a3307d2c
geode-core/src/main/java/org/apache/geode/security/templates/SamplePostProcessor.java bcf40cfcb9cd41d9287ebcd78534ab2d3485aeb1
geode-core/src/test/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtilTest.java 6ab1d4be3d4803cbc29ce9ebda056aef4d9383e3
geode-core/src/test/java/com/gemstone/gemfire/internal/security/IntegratedSecurityServiceTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/security/SecurityConfigIntegrationTest.java d0a2130755f8bfe91940c457cf8d5ef1bcc23f7f
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilCustomRealmJUnitTest.java 625e48fc69e95fb8ca2cf85d9a70aaa99d013983
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java 3a7b4ded06a7f6d167f02de124d9ab1f1eebfa92
geode-core/src/test/java/com/gemstone/gemfire/security/NoShowValue1PostProcessor.java d4565166c380e6340ebc094502a4b8027051fec8
geode-core/src/test/java/com/gemstone/gemfire/security/PDXGfshPostProcessorOnRemoteServerTest.java 498bd3acbe88949b2f45c7eb1a085480a9752d03
geode-core/src/test/java/com/gemstone/gemfire/security/PDXPostProcessor.java c51c9d84b6f877b148fb08f3e6dbb13d59860546
geode-core/src/test/java/com/gemstone/gemfire/security/PDXPostProcessorDUnitTest.java 2a5727c6c88d42c7f6bb5ea4cb62dc62ae8d1382
geode-cq/src/test/java/com/gemstone/gemfire/security/CQPDXPostProcessorDUnitTest.java b6d520f6354f244a6af14b954a91ef69b873719d
Diff: https://reviews.apache.org/r/51849/diff/
Testing
-------
Thanks,
Jinmei Liao
Re: Review Request 51849: GEODE-17: consolidate GeodeSecurityUtil and
IntegratedSecurityService
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51849/#review149092
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java (line 1681)
<https://reviews.apache.org/r/51849/#comment216609>
In order to correctly support unit testing best practices including mocking, IntegratedSecurityService.getSecurityService() should be called once per instance of this class with the result placed in a member variable such as:
private SecurityService securityService = IntegratedSecurityService.getSecurityService();
Then code lines like this one would change to:
Object newValue = this.securityService.postProcess(clientMessage.getRegionName(), clientMessage.getKeyOfInterest(), oldValue, clientMessage.valueIsObject());
- Kirk Lund
On Sept. 13, 2016, 4:45 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51849/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2016, 4:45 p.m.)
>
>
> Review request for geode, Kevin Duling and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-17: consolidate GeodeSecurityUtil and IntegratedSecurityService
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java e94ef353889d7ea051ec4975aba74aab5fc00bd5
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java 260121dcc0b08e37869169931ee380a3d248fa3e
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/IntegratedSecurityService.java d294859a2652f01621ddd1b4e259e78c1f4cf16f
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/SecurityService.java c97575141e93aca71b14e2c63937f69174589356
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java ad27ec33e0f3f147f410e194658569e0c11b0e8d
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java f3c771f308e9b492a223a110ec130c9f07278dfb
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/domain/DataCommandRequest.java 76582c329aad8d3d8055ee87ab9ea39364f7cdc4
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java 27082424e5353692d0a51fe41dd0cbc99fbecd0f
> geode-core/src/main/java/org/apache/geode/security/PostProcessor.java 3c50ecc1e526f43a6eb861285fa17cf1a3307d2c
> geode-core/src/main/java/org/apache/geode/security/templates/SamplePostProcessor.java bcf40cfcb9cd41d9287ebcd78534ab2d3485aeb1
> geode-core/src/test/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtilTest.java 6ab1d4be3d4803cbc29ce9ebda056aef4d9383e3
> geode-core/src/test/java/com/gemstone/gemfire/internal/security/IntegratedSecurityServiceTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/security/SecurityConfigIntegrationTest.java d0a2130755f8bfe91940c457cf8d5ef1bcc23f7f
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilCustomRealmJUnitTest.java 625e48fc69e95fb8ca2cf85d9a70aaa99d013983
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java 3a7b4ded06a7f6d167f02de124d9ab1f1eebfa92
> geode-core/src/test/java/com/gemstone/gemfire/security/NoShowValue1PostProcessor.java d4565166c380e6340ebc094502a4b8027051fec8
> geode-core/src/test/java/com/gemstone/gemfire/security/PDXGfshPostProcessorOnRemoteServerTest.java 498bd3acbe88949b2f45c7eb1a085480a9752d03
> geode-core/src/test/java/com/gemstone/gemfire/security/PDXPostProcessor.java c51c9d84b6f877b148fb08f3e6dbb13d59860546
> geode-core/src/test/java/com/gemstone/gemfire/security/PDXPostProcessorDUnitTest.java 2a5727c6c88d42c7f6bb5ea4cb62dc62ae8d1382
> geode-cq/src/test/java/com/gemstone/gemfire/security/CQPDXPostProcessorDUnitTest.java b6d520f6354f244a6af14b954a91ef69b873719d
>
> Diff: https://reviews.apache.org/r/51849/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 51849: GEODE-17: consolidate GeodeSecurityUtil and
IntegratedSecurityService
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51849/#review149138
-----------------------------------------------------------
Ship it!
If the open issue was resolved then Ship It!
- Kirk Lund
On Sept. 13, 2016, 4:45 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51849/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2016, 4:45 p.m.)
>
>
> Review request for geode, Kevin Duling and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-17: consolidate GeodeSecurityUtil and IntegratedSecurityService
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java e94ef353889d7ea051ec4975aba74aab5fc00bd5
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java 260121dcc0b08e37869169931ee380a3d248fa3e
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/IntegratedSecurityService.java d294859a2652f01621ddd1b4e259e78c1f4cf16f
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/SecurityService.java c97575141e93aca71b14e2c63937f69174589356
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java ad27ec33e0f3f147f410e194658569e0c11b0e8d
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java f3c771f308e9b492a223a110ec130c9f07278dfb
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/domain/DataCommandRequest.java 76582c329aad8d3d8055ee87ab9ea39364f7cdc4
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java 27082424e5353692d0a51fe41dd0cbc99fbecd0f
> geode-core/src/main/java/org/apache/geode/security/PostProcessor.java 3c50ecc1e526f43a6eb861285fa17cf1a3307d2c
> geode-core/src/main/java/org/apache/geode/security/templates/SamplePostProcessor.java bcf40cfcb9cd41d9287ebcd78534ab2d3485aeb1
> geode-core/src/test/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtilTest.java 6ab1d4be3d4803cbc29ce9ebda056aef4d9383e3
> geode-core/src/test/java/com/gemstone/gemfire/internal/security/IntegratedSecurityServiceTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/security/SecurityConfigIntegrationTest.java d0a2130755f8bfe91940c457cf8d5ef1bcc23f7f
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilCustomRealmJUnitTest.java 625e48fc69e95fb8ca2cf85d9a70aaa99d013983
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java 3a7b4ded06a7f6d167f02de124d9ab1f1eebfa92
> geode-core/src/test/java/com/gemstone/gemfire/security/NoShowValue1PostProcessor.java d4565166c380e6340ebc094502a4b8027051fec8
> geode-core/src/test/java/com/gemstone/gemfire/security/PDXGfshPostProcessorOnRemoteServerTest.java 498bd3acbe88949b2f45c7eb1a085480a9752d03
> geode-core/src/test/java/com/gemstone/gemfire/security/PDXPostProcessor.java c51c9d84b6f877b148fb08f3e6dbb13d59860546
> geode-core/src/test/java/com/gemstone/gemfire/security/PDXPostProcessorDUnitTest.java 2a5727c6c88d42c7f6bb5ea4cb62dc62ae8d1382
> geode-cq/src/test/java/com/gemstone/gemfire/security/CQPDXPostProcessorDUnitTest.java b6d520f6354f244a6af14b954a91ef69b873719d
>
> Diff: https://reviews.apache.org/r/51849/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 51849: GEODE-17: consolidate GeodeSecurityUtil and
IntegratedSecurityService
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51849/
-----------------------------------------------------------
(Updated Sept. 13, 2016, 4:45 p.m.)
Review request for geode, Kevin Duling and Kirk Lund.
Repository: geode
Description
-------
GEODE-17: consolidate GeodeSecurityUtil and IntegratedSecurityService
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java e94ef353889d7ea051ec4975aba74aab5fc00bd5
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java 260121dcc0b08e37869169931ee380a3d248fa3e
geode-core/src/main/java/com/gemstone/gemfire/internal/security/IntegratedSecurityService.java d294859a2652f01621ddd1b4e259e78c1f4cf16f
geode-core/src/main/java/com/gemstone/gemfire/internal/security/SecurityService.java c97575141e93aca71b14e2c63937f69174589356
geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java ad27ec33e0f3f147f410e194658569e0c11b0e8d
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java f3c771f308e9b492a223a110ec130c9f07278dfb
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/domain/DataCommandRequest.java 76582c329aad8d3d8055ee87ab9ea39364f7cdc4
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java 27082424e5353692d0a51fe41dd0cbc99fbecd0f
geode-core/src/main/java/org/apache/geode/security/PostProcessor.java 3c50ecc1e526f43a6eb861285fa17cf1a3307d2c
geode-core/src/main/java/org/apache/geode/security/templates/SamplePostProcessor.java bcf40cfcb9cd41d9287ebcd78534ab2d3485aeb1
geode-core/src/test/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtilTest.java 6ab1d4be3d4803cbc29ce9ebda056aef4d9383e3
geode-core/src/test/java/com/gemstone/gemfire/internal/security/IntegratedSecurityServiceTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/security/SecurityConfigIntegrationTest.java d0a2130755f8bfe91940c457cf8d5ef1bcc23f7f
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilCustomRealmJUnitTest.java 625e48fc69e95fb8ca2cf85d9a70aaa99d013983
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java 3a7b4ded06a7f6d167f02de124d9ab1f1eebfa92
geode-core/src/test/java/com/gemstone/gemfire/security/NoShowValue1PostProcessor.java d4565166c380e6340ebc094502a4b8027051fec8
geode-core/src/test/java/com/gemstone/gemfire/security/PDXGfshPostProcessorOnRemoteServerTest.java 498bd3acbe88949b2f45c7eb1a085480a9752d03
geode-core/src/test/java/com/gemstone/gemfire/security/PDXPostProcessor.java c51c9d84b6f877b148fb08f3e6dbb13d59860546
geode-core/src/test/java/com/gemstone/gemfire/security/PDXPostProcessorDUnitTest.java 2a5727c6c88d42c7f6bb5ea4cb62dc62ae8d1382
geode-cq/src/test/java/com/gemstone/gemfire/security/CQPDXPostProcessorDUnitTest.java b6d520f6354f244a6af14b954a91ef69b873719d
Diff: https://reviews.apache.org/r/51849/diff/
Testing (updated)
-------
precheckin
Thanks,
Jinmei Liao