You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Nitay Joffe (JIRA)" <ji...@apache.org> on 2012/11/07 08:34:12 UTC
[jira] [Created] (GIRAPH-413) Make building Facebook profile easier
Nitay Joffe created GIRAPH-413:
----------------------------------
Summary: Make building Facebook profile easier
Key: GIRAPH-413
URL: https://issues.apache.org/jira/browse/GIRAPH-413
Project: Giraph
Issue Type: Improvement
Reporter: Nitay Joffe
Assignee: Nitay Joffe
Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories, we can just include the built jar in our codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and lowers the barrier for using this profile.
Also now the following works:
>> dev-support/for-each-profile.sh clean install
Rebuilds current codebase on every profile. In fact this is how I tested the patch :).
I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having this instead of just having everyone consistently use -Phadoop_xx?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-413) Make building Facebook profile easier
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-413:
-------------------------------
Description:
Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories, we can just include the built jar in our
codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and lowers the barrier for using this profile.
Also now the following works:
>> dev-support/for-each-profile.sh clean install
Rebuilds current codebase on every profile. Some profiles are still failing in formats because they don't work with the given hadoop version, but the script now functions.
I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having this instead of just having everyone consistently use -Phadoop_xx?
https://reviews.apache.org/r/7924/
was:
Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories, we can just include the built jar in our
codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and lowers the barrier for using this profile.
Also now the following works:
>> dev-support/for-each-profile.sh clean install
Rebuilds current codebase on every profile. In fact this is how I tested the patch :).
I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having this instead of just having everyone consistently use -Phadoop_xx?
https://reviews.apache.org/r/7924/
> Make building Facebook profile easier
> -------------------------------------
>
> Key: GIRAPH-413
> URL: https://issues.apache.org/jira/browse/GIRAPH-413
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-413.patch, hadoop-0.20.1-dev-core.jar
>
>
> Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories, we can just include the built jar in our
> codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and lowers the barrier for using this profile.
> Also now the following works:
> >> dev-support/for-each-profile.sh clean install
> Rebuilds current codebase on every profile. Some profiles are still failing in formats because they don't work with the given hadoop version, but the script now functions.
> I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having this instead of just having everyone consistently use -Phadoop_xx?
> https://reviews.apache.org/r/7924/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-413) Make building Facebook profile
easier
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495001#comment-13495001 ]
Eli Reisman commented on GIRAPH-413:
------------------------------------
I have always liked the idea of -P being the single point of reference for selecting a profile to run rather than -D getting involved too.
> Make building Facebook profile easier
> -------------------------------------
>
> Key: GIRAPH-413
> URL: https://issues.apache.org/jira/browse/GIRAPH-413
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-413-2.patch, GIRAPH-413.patch, hadoop-0.20-core.jar
>
>
> Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories, we can just include the built jar in our
> codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and lowers the barrier for using this profile.
> Also now the following works:
> >> dev-support/for-each-profile.sh clean install
> Rebuilds current codebase on every profile. Some profiles are still failing in formats because they don't work with the given hadoop version, but the script now functions.
> I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having this instead of just having everyone consistently use -Phadoop_xx?
> https://reviews.apache.org/r/7924/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-413) Make building Facebook profile easier
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-413:
-------------------------------
Attachment: (was: hadoop-0.20.1-dev-core.jar)
> Make building Facebook profile easier
> -------------------------------------
>
> Key: GIRAPH-413
> URL: https://issues.apache.org/jira/browse/GIRAPH-413
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-413-2.patch, GIRAPH-413.patch, hadoop-0.20-core.jar
>
>
> Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories, we can just include the built jar in our
> codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and lowers the barrier for using this profile.
> Also now the following works:
> >> dev-support/for-each-profile.sh clean install
> Rebuilds current codebase on every profile. Some profiles are still failing in formats because they don't work with the given hadoop version, but the script now functions.
> I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having this instead of just having everyone consistently use -Phadoop_xx?
> https://reviews.apache.org/r/7924/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-413) Make building Facebook profile easier
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-413:
-------------------------------
Attachment: hadoop-0.20.1-dev-core.jar
GIRAPH-413.patch
Note the patch doesn't include lib/hadoop-0.20.1-dev-core.jar since it's a binary file, so I included it separately. Make sure to add it when committing the patch.
> Make building Facebook profile easier
> -------------------------------------
>
> Key: GIRAPH-413
> URL: https://issues.apache.org/jira/browse/GIRAPH-413
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-413.patch, hadoop-0.20.1-dev-core.jar
>
>
> Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories, we can just include the built jar in our
> codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and lowers the barrier for using this profile.
> Also now the following works:
> >> dev-support/for-each-profile.sh clean install
> Rebuilds current codebase on every profile. In fact this is how I tested the patch :).
> I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having this instead of just having everyone consistently use -Phadoop_xx?
> https://reviews.apache.org/r/7924/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-413) Make building Facebook profile
easier
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493616#comment-13493616 ]
Avery Ching commented on GIRAPH-413:
------------------------------------
+1, This looks good to me. Anyone have any objections? If not I'll commit later tonight.
> Make building Facebook profile easier
> -------------------------------------
>
> Key: GIRAPH-413
> URL: https://issues.apache.org/jira/browse/GIRAPH-413
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-413-2.patch, GIRAPH-413.patch, hadoop-0.20-core.jar
>
>
> Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories, we can just include the built jar in our
> codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and lowers the barrier for using this profile.
> Also now the following works:
> >> dev-support/for-each-profile.sh clean install
> Rebuilds current codebase on every profile. Some profiles are still failing in formats because they don't work with the given hadoop version, but the script now functions.
> I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having this instead of just having everyone consistently use -Phadoop_xx?
> https://reviews.apache.org/r/7924/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-413) Make building Facebook profile easier
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-413:
-------------------------------
Description:
Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories, we can just include the built jar in our
codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and lowers the barrier for using this profile.
Also now the following works:
>> dev-support/for-each-profile.sh clean install
Rebuilds current codebase on every profile. In fact this is how I tested the patch :).
I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having this instead of just having everyone consistently use -Phadoop_xx?
https://reviews.apache.org/r/7924/
was:
Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories, we can just include the built jar in our codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and lowers the barrier for using this profile.
Also now the following works:
>> dev-support/for-each-profile.sh clean install
Rebuilds current codebase on every profile. In fact this is how I tested the patch :).
I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having this instead of just having everyone consistently use -Phadoop_xx?
> Make building Facebook profile easier
> -------------------------------------
>
> Key: GIRAPH-413
> URL: https://issues.apache.org/jira/browse/GIRAPH-413
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
>
> Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories, we can just include the built jar in our
> codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and lowers the barrier for using this profile.
> Also now the following works:
> >> dev-support/for-each-profile.sh clean install
> Rebuilds current codebase on every profile. In fact this is how I tested the patch :).
> I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having this instead of just having everyone consistently use -Phadoop_xx?
> https://reviews.apache.org/r/7924/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-413) Make building Facebook profile
easier
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493819#comment-13493819 ]
Hudson commented on GIRAPH-413:
-------------------------------
Integrated in Giraph-trunk-Commit #277 (See [https://builds.apache.org/job/Giraph-trunk-Commit/277/])
GIRAPH-413: Make building Facebook profile easier. (nitay via aching) (Revision 1407375)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407375
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/README
* /giraph/trunk/dev-support/for-each-profile.sh
* /giraph/trunk/giraph-formats-contrib/pom.xml
* /giraph/trunk/giraph/pom.xml
* /giraph/trunk/lib
* /giraph/trunk/lib/hadoop-0.20-core.jar
* /giraph/trunk/pom.xml
> Make building Facebook profile easier
> -------------------------------------
>
> Key: GIRAPH-413
> URL: https://issues.apache.org/jira/browse/GIRAPH-413
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-413-2.patch, GIRAPH-413.patch, hadoop-0.20-core.jar
>
>
> Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories, we can just include the built jar in our
> codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and lowers the barrier for using this profile.
> Also now the following works:
> >> dev-support/for-each-profile.sh clean install
> Rebuilds current codebase on every profile. Some profiles are still failing in formats because they don't work with the given hadoop version, but the script now functions.
> I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having this instead of just having everyone consistently use -Phadoop_xx?
> https://reviews.apache.org/r/7924/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-413) Make building Facebook profile easier
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-413:
-------------------------------
Attachment: hadoop-0.20-core.jar
GIRAPH-413-2.patch
> Make building Facebook profile easier
> -------------------------------------
>
> Key: GIRAPH-413
> URL: https://issues.apache.org/jira/browse/GIRAPH-413
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-413-2.patch, GIRAPH-413.patch, hadoop-0.20-core.jar
>
>
> Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories, we can just include the built jar in our
> codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and lowers the barrier for using this profile.
> Also now the following works:
> >> dev-support/for-each-profile.sh clean install
> Rebuilds current codebase on every profile. Some profiles are still failing in formats because they don't work with the given hadoop version, but the script now functions.
> I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having this instead of just having everyone consistently use -Phadoop_xx?
> https://reviews.apache.org/r/7924/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira