[GitHub] [orc] guiyanakuang commented on a diff in pull request #1415: ORC-1375: Cancel old running ci tasks when a pr has a new commit

["guiyanakuang (via GitHub)" <gi...@apache.org>]

guiyanakuang commented on code in PR #1415:
URL: https://github.com/apache/orc/pull/1415#discussion_r1111467040


##########
.github/workflows/build_and_test.yml:
##########
@@ -14,6 +14,11 @@ on:
     branches:
     - main
 
+# Cancel previous PR build and test
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.event.number || github.sha }}

Review Comment:
   I think it's enough, almost all contributions are currently committed by pull request. Also when we use to receive other events, we can degrade to grouping using `github.sha`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org