You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/01 08:56:25 UTC

[GitHub] [skywalking] codecov-io edited a comment on issue #4292: Improve ES query performance

codecov-io edited a comment on issue #4292: Improve ES query performance
URL: https://github.com/apache/skywalking/pull/4292#issuecomment-580654810
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4292?src=pr&el=h1) Report
   > Merging [#4292](https://codecov.io/gh/apache/skywalking/pull/4292?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9118e984f478b6a57cd66ece2ff9db3a9ed8000f?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `18.36%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4292/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4292?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #4292      +/-   ##
   =========================================
   - Coverage   26.82%   26.8%   -0.02%     
   =========================================
     Files        1168    1170       +2     
     Lines       25524   25579      +55     
     Branches     3638    3655      +17     
   =========================================
   + Hits         6846    6856      +10     
   - Misses      18073   18113      +40     
   - Partials      605     610       +5
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4292?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...mons/interceptor/RestMappingMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9SZXN0TWFwcGluZ01ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...s/interceptor/RequestMappingMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9SZXF1ZXN0TWFwcGluZ01ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...lking/oap/query/graphql/resolver/ProfileQuery.java](https://codecov.io/gh/apache/skywalking/pull/4292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL1Byb2ZpbGVRdWVyeS5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...g/apm/plugin/spring/mvc/commons/ParsePathUtil.java](https://codecov.io/gh/apache/skywalking/pull/4292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9QYXJzZVBhdGhVdGlsLmphdmE=) | `0% <0%> (ø)` | |
   | [...ugin/match/MethodInheritanceAnnotationMatcher.java](https://codecov.io/gh/apache/skywalking/pull/4292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL01ldGhvZEluaGVyaXRhbmNlQW5ub3RhdGlvbk1hdGNoZXIuamF2YQ==) | `72% <72%> (ø)` | |
   | [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `28.73% <0%> (-8.05%)` | :arrow_down: |
   | [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `60.88% <0%> (-0.45%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4292?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4292?src=pr&el=footer). Last update [9118e98...1abe96f](https://codecov.io/gh/apache/skywalking/pull/4292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services