[jira] [Work logged] (TOMEE-2988) Upgrade xbean to 4.18+ (Java 16 support)

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TOMEE-2988?focusedWorklogId=575449&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-575449 ]

ASF GitHub Bot logged work on TOMEE-2988:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/21 11:16
            Start Date: 01/Apr/21 11:16
    Worklog Time Spent: 10m 
      Work Description: rzo1 commented on a change in pull request #776:
URL: https://github.com/apache/tomee/pull/776#discussion_r605572170



##########
File path: container/openejb-core/pom.xml
##########
@@ -562,11 +562,31 @@
     <!-- End: JavaMail -->
     <dependency>
       <groupId>org.apache.xbean</groupId>
-      <artifactId>xbean-asm7-shaded</artifactId>
+      <artifactId>xbean-asm9-shaded</artifactId>
+      <exclusions>
+        <exclusion>
+          <groupId>org.ow2.asm</groupId>
+          <artifactId>asm</artifactId>
+        </exclusion>
+        <exclusion>
+          <groupId>org.ow2.asm</groupId>
+          <artifactId>asm-commons</artifactId>
+        </exclusion>
+      </exclusions>
     </dependency>
     <dependency>
       <groupId>org.apache.xbean</groupId>
       <artifactId>xbean-finder-shaded</artifactId>
+      <exclusions>

Review comment:
       see above

##########
File path: arquillian/arquillian-tomee-common/pom.xml
##########
@@ -86,6 +86,16 @@
       <artifactId>xbean-finder-shaded</artifactId>
       <version>${xbeanVersion}</version>
       <scope>provided</scope>
+      <exclusions>

Review comment:
       I am wondering:
   
   Is this needed?  Afaik [xbean-finder-shaded](https://mvnrepository.com/artifact/org.apache.xbean/xbean-finder-shaded/4.18) only has a compile dependency towards `xbean-asm9-shaded`. The `org.ow2.asm` stuff is a transient dependency of `xbean-asm9-shaded`. So shouldn't we exclude  `xbean-asm9-shaded` here as it comes from `openwebbeans` anyway?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 575449)
    Time Spent: 0.5h  (was: 20m)

> Upgrade xbean to 4.18+ (Java 16 support)
> ----------------------------------------
>
>                 Key: TOMEE-2988
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2988
>             Project: TomEE
>          Issue Type: Task
>            Reporter: Vicente Rossello Jaume
>            Assignee: Vicente Rossello Jaume
>            Priority: Minor
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> We need asm9 to support java 16



--
This message was sent by Atlassian Jira
(v8.3.4#803005)