[GitHub] [skywalking] hanahmily commented on a diff in pull request #10233: Improve BanyanDB measure schema

[GitBox <gi...@apache.org>]

hanahmily commented on code in PR #10233:
URL: https://github.com/apache/skywalking/pull/10233#discussion_r1062484743


##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/ScopeDefaultColumn.java:
##########
@@ -34,14 +34,16 @@ public class ScopeDefaultColumn {
     private String columnName;
     private Class<?> type;
     private boolean isID;
+    private boolean banyandbNoIndexing;
     private int length;
 
-    public ScopeDefaultColumn(String fieldName, String columnName, Class<?> type, boolean isID, int length) {
+    public ScopeDefaultColumn(String fieldName, String columnName, Class<?> type, boolean isID, int length, boolean banyandbNoIndexing) {

Review Comment:
   `service_id` is defined by `ScopeDefaultColumn`.  IIUC, `ScopeDefaultColumn.columnName` defines the column name in the storage layer. Essentially, I tend to mark `service_id` as a non-indexed tag. Adding a new field seems relevant. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org