You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "darenwkt (via GitHub)" <gi...@apache.org> on 2023/04/19 15:07:00 UTC
[GitHub] [flink-kubernetes-operator] darenwkt opened a new pull request, #570: Observer plugin
darenwkt opened a new pull request, #570:
URL: https://github.com/apache/flink-kubernetes-operator/pull/570
<!--
*Thank you very much for contributing to the Apache Flink Kubernetes Operator - we are happy that you want to help us improve the project. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix][docs] Fix typo in event time introduction` or `[hotfix][javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can read more on how we use GitHub Actions for CI [here](https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/development/guide/#cicd).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Support pluginable Observer to allow user to load a plugin JAR to run custom observer logic.
## Brief change log
- Added FlinkResourceObserverPlugin interface for users to implement in plugin JAR with custom observer logic.
## Verifying this change
<!--
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
-->
- Added unit test to verify TestObserverPlugin is discoverable.
- Manual test by loading a sample JAR that changes the jobName in FlinkSessionJob status field and verified successfully.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changes to the `CustomResourceDescriptors`: ( no)
- Core observer or reconciler logic that is regularly executed: (yes)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #570: [FLINK-31857] Observer plugin
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on PR #570:
URL: https://github.com/apache/flink-kubernetes-operator/pull/570#issuecomment-1516404226
I think we should design this together with the reconciler plugin and there should be a FLIP for it to make sure that other users can influence the design and we cover existing features like the autoscaler etc with the pluggable mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] darenwkt closed pull request #570: [FLINK-31857] Observer plugin
Posted by "darenwkt (via GitHub)" <gi...@apache.org>.
darenwkt closed pull request #570: [FLINK-31857] Observer plugin
URL: https://github.com/apache/flink-kubernetes-operator/pull/570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org