[GitHub] [druid] benkrug commented on pull request #10877: Allow coordinator to be configured to kill segments in future

[GitBox <gi...@apache.org>]

benkrug commented on PR #10877:
URL: https://github.com/apache/druid/pull/10877#issuecomment-1132104902

   druid.coordinator.kill.durationToRetain can only be set to one value at a time.  Wouldn't it make sense, in the spirit of this PR, to have a "+ or - my-ISO-period" option?  
   
   I'm late to the game, but this PR allows us to use durationToRetain to kill past OR future segments.  (Or, as mentioned in https://github.com/apache/druid/issues/12526 we can ignoreDurationToRetain, yolo.)  It would be nice to have an AND option, ie, kill past and future segments. Ie, have a rolling window, keep a week back and a week ahead, other outlying data, go ahead and clean up.  If someone is ingesting data that for whatever reason includes past and future, as it is now, they have to choose between positive and negative durationToRetain, and I guess handle the other option manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org