You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/03 15:27:27 UTC

[GitHub] [airflow] michalslowikowski00 opened a new pull request #7021: [AIRFLOW-6116] [AIP-21] Rename MLEngine operators

michalslowikowski00 opened a new pull request #7021: [AIRFLOW-6116] [AIP-21] Rename MLEngine operators
URL: https://github.com/apache/airflow/pull/7021
 
 
   PR contains changes regarding AIP-21 (renaming GCP operators and hooks):
   * renamed GCP modules
   * adde deprecation warnings to the contrib modules
   * fixed tests
   * updated UPDATING.md
   
   ---
   Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6116
   
   - [x] Description above provides context of the change
   - [x] Commit message starts with `[AIRFLOW-NNNN]`, where AIRFLOW-NNNN = JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   (*) For document-only changes, no JIRA issue is needed. Commit message starts `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin merged pull request #7021: [AIRFLOW-6116] [AIP-21] Rename GCP MLEngine operators

Posted by GitBox <gi...@apache.org>.
nuclearpinguin merged pull request #7021: [AIRFLOW-6116] [AIP-21] Rename GCP MLEngine operators
URL: https://github.com/apache/airflow/pull/7021
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on issue #7021: [AIRFLOW-6116] [AIP-21] Rename MLEngine operators

Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on issue #7021: [AIRFLOW-6116] [AIP-21] Rename MLEngine operators
URL: https://github.com/apache/airflow/pull/7021#issuecomment-570665508
 
 
   Travis is sad :<

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7021: [AIRFLOW-6116] [AIP-21] Rename GCP MLEngine operators

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7021: [AIRFLOW-6116] [AIP-21] Rename GCP MLEngine operators
URL: https://github.com/apache/airflow/pull/7021#issuecomment-571258123
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=h1) Report
   > Merging [#7021](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/09c895ee72cc8d2cb2e73ffb28a2a2fe5cb32fef?src=pr&el=desc) will **increase** coverage by `0.26%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7021/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7021      +/-   ##
   ==========================================
   + Coverage   84.76%   85.03%   +0.26%     
   ==========================================
     Files         679      680       +1     
     Lines       38647    39427     +780     
   ==========================================
   + Hits        32761    33525     +764     
   - Misses       5886     5902      +16
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/contrib/operators/mlengine\_operator.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9tbGVuZ2luZV9vcGVyYXRvci5weQ==) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/gcp/utils/mlengine\_operator\_utils.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvdXRpbHMvbWxlbmdpbmVfb3BlcmF0b3JfdXRpbHMucHk=) | `95.34% <100%> (ø)` | :arrow_up: |
   | [airflow/gcp/example\_dags/example\_mlengine.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfbWxlbmdpbmUucHk=) | `84.48% <100%> (ø)` | :arrow_up: |
   | [airflow/gcp/operators/mlengine.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL21sZW5naW5lLnB5) | `89.51% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==) | `100% <0%> (ø)` | :arrow_up: |
   | ... and [13 more](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=footer). Last update [09c895e...8e96221](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7021: [AIRFLOW-6116] [AIP-21] Rename GCP MLEngine operators

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7021: [AIRFLOW-6116] [AIP-21] Rename GCP MLEngine operators
URL: https://github.com/apache/airflow/pull/7021#issuecomment-571258123
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=h1) Report
   > Merging [#7021](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/748e3c3519b6cfeb82929efa6cc2d11ca0154b49?src=pr&el=desc) will **decrease** coverage by `0.27%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7021/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #7021      +/-   ##
   =========================================
   - Coverage   85.07%   84.8%   -0.28%     
   =========================================
     Files         680     680              
     Lines       38810   38826      +16     
   =========================================
   - Hits        33019   32925      -94     
   - Misses       5791    5901     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/contrib/operators/mlengine\_operator.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9tbGVuZ2luZV9vcGVyYXRvci5weQ==) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/gcp/utils/mlengine\_operator\_utils.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvdXRpbHMvbWxlbmdpbmVfb3BlcmF0b3JfdXRpbHMucHk=) | `95.34% <100%> (ø)` | :arrow_up: |
   | [airflow/gcp/example\_dags/example\_mlengine.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfbWxlbmdpbmUucHk=) | `84.48% <100%> (ø)` | :arrow_up: |
   | [airflow/gcp/operators/mlengine.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL21sZW5naW5lLnB5) | `89.51% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7021/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=footer). Last update [748e3c3...09bb637](https://codecov.io/gh/apache/airflow/pull/7021?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services