[jira] [Commented] (STORM-1082) Fix the property parameters used in Kafka tests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940284#comment-14940284 ] 

ASF GitHub Bot commented on STORM-1082:
---------------------------------------

GitHub user zhuoliu opened a pull request:

    https://github.com/apache/storm/pull/777

    STORM-1082 fix nits for properties in kafka tests

    rename "request.required.acks" to "acks", delete the obsoleted "serializer.class"

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhuoliu/storm 1082

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #777
    
----
commit f2a35a38929035f5cf352d8e6bf72afe40b69358
Author: zhuol <zh...@yahoo-inc.com>
Date:   2015-10-01T19:33:10Z

    STORM-1082 fix nits for properties in kafka tests

----


> Fix the property parameters used in Kafka tests
> -----------------------------------------------
>
>                 Key: STORM-1082
>                 URL: https://issues.apache.org/jira/browse/STORM-1082
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-kafka
>            Reporter: Zhuo Liu
>            Assignee: Zhuo Liu
>            Priority: Minor
>
> "request.required.acks" in new KafkaProducer API has been renamed to "acks", we need to fix that. Also the "serializer.class" is obsolete.
> The 8.3 Kafka documentation is not perfect for this configuration yet (see KAFKA-2602).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)