You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/23 03:40:53 UTC
[GitHub] [pulsar] Nicklee007 opened a new pull request, #16189: [fix][broker] fix the incorrect swagger response parameter type
Nicklee007 opened a new pull request, #16189:
URL: https://github.com/apache/pulsar/pull/16189
### Motivation
modify the incorrect swagger response parameter type in `ClustersBase.class`
### Modifications
modify the incorrect swagger response parameter type.
- [X] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Nicklee007 commented on pull request #16189: [fix][broker] fix the incorrect swagger response parameter type
Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16189:
URL: https://github.com/apache/pulsar/pull/16189#issuecomment-1181648491
@merlimat In the PR https://github.com/apache/pulsar/pull/10818 you changed the API return type but ignore change the swagger response class type. This PR will fix it, please take a look, Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Nicklee007 commented on pull request #16189: [fix][broker] fix the incorrect swagger response parameter type
Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16189:
URL: https://github.com/apache/pulsar/pull/16189#issuecomment-1168698644
@HQebupt PTAL, Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16189: [fix][broker] fix the incorrect swagger response parameter type
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16189:
URL: https://github.com/apache/pulsar/pull/16189#issuecomment-1236234256
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Nicklee007 commented on pull request #16189: [fix][broker] fix the incorrect swagger response parameter type
Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16189:
URL: https://github.com/apache/pulsar/pull/16189#issuecomment-1204685657
@merlimat In the PR https://github.com/apache/pulsar/pull/10818 you changed the API return type but ignore change the swagger response class type. This PR will fix it, please take a look, Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on a diff in pull request #16189: [fix][broker] fix the incorrect swagger response parameter type
Posted by GitBox <gi...@apache.org>.
HQebupt commented on code in PR #16189:
URL: https://github.com/apache/pulsar/pull/16189#discussion_r906660399
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java:
##########
@@ -99,7 +98,7 @@ public void getClusters(@Suspended AsyncResponse asyncResponse) {
@Path("/{cluster}")
@ApiOperation(
value = "Get the configuration for the specified cluster.",
- response = ClusterDataImpl.class,
+ response = ClusterData.class,
Review Comment:
It does not seem a bug. Is there an error when calling the Api ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Nicklee007 commented on a diff in pull request #16189: [fix][broker] fix the incorrect swagger response parameter type
Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on code in PR #16189:
URL: https://github.com/apache/pulsar/pull/16189#discussion_r906928236
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java:
##########
@@ -99,7 +98,7 @@ public void getClusters(@Suspended AsyncResponse asyncResponse) {
@Path("/{cluster}")
@ApiOperation(
value = "Get the configuration for the specified cluster.",
- response = ClusterDataImpl.class,
+ response = ClusterData.class,
Review Comment:
the function return POJO is ClusterData.class but set in swagger is ClusterDataImpl.class and also will show to user the incorrect return type. It will meet some error when we through restful api to invoke the method and want to transfer the result to ClusterData.class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Nicklee007 commented on pull request #16189: [fix][broker] fix the incorrect swagger response parameter type
Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16189:
URL: https://github.com/apache/pulsar/pull/16189#issuecomment-1195399107
@merlimat In the PR https://github.com/apache/pulsar/pull/10818 you changed the API return type but ignore change the swagger response class type. This PR will fix it, please take a look, Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Nicklee007 commented on pull request #16189: [fix][broker] fix the incorrect swagger response parameter type
Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16189:
URL: https://github.com/apache/pulsar/pull/16189#issuecomment-1170852316
@merlimat In the PR #10818 you changed the API return type but ignore change the swagger response class type. This PR will fix it, please take a look, Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org