You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/08/01 19:16:18 UTC

[GitHub] sachouche commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

sachouche commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.
URL: https://github.com/apache/drill/pull/1344#discussion_r206996050
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
 ##########
 @@ -1175,6 +1175,7 @@ public AggIterOutcome outputCurrentBatch() {
       v.getValueVector().getMutator().setValueCount(numOutputRecords);
     }
 
+    outContainer.setRecordCount(numOutputRecords);
 
 Review comment:
   Noticed the old code is using INFO debug level; shouldn't it be using debug?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services