You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/07 21:41:42 UTC
[GitHub] [airflow] NiloFreitas opened a new pull request #22062: Patch Dataproc documentation
NiloFreitas opened a new pull request #22062:
URL: https://github.com/apache/airflow/pull/22062
Added the example of DataprocInstantiateInlineWorkflowTemplateOperator in the documentation and example DAG
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22062: Patch Dataproc documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22062:
URL: https://github.com/apache/airflow/pull/22062#issuecomment-1061738866
It needs some fixes in the list of documentation left.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #22062: Patch Dataproc documentation
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #22062:
URL: https://github.com/apache/airflow/pull/22062#issuecomment-1061270620
Can you add a reference to this section in Python API reference docs?
https://github.com/apache/airflow/blob/fb6b2d1fee6af366a3311a8012eb35b8f665348a/airflow/providers/google/cloud/operators/bigquery.py#L126-L128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22062: Patch Dataproc documentation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22062:
URL: https://github.com/apache/airflow/pull/22062#issuecomment-1061178023
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #22062: Add guide for DataprocInstantiateInlineWorkflowTemplateOperator
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #22062:
URL: https://github.com/apache/airflow/pull/22062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NiloFreitas commented on pull request #22062: Patch Dataproc documentation
Posted by GitBox <gi...@apache.org>.
NiloFreitas commented on pull request #22062:
URL: https://github.com/apache/airflow/pull/22062#issuecomment-1061280873
The Python API reference docs for the DataprocInstantiateInlineWorkflowTemplateOperator already has a reference (which is broken):
> .. seealso::
> Please refer to:
> https://cloud.google.com/dataproc/docs/reference/rest/v1beta2/projects.regions.workflowTemplates/instantiateInline
So you want me to replace it with this
> .. seealso::
> For more information on how to use this operator, take a look at the guide:
> :ref:`howto/operator:DataprocInstantiateInlineWorkflowTemplateOperator`
Or fix the link with this reference?
> .. seealso::
> Please refer to:
> https://cloud.google.com/dataproc/docs/reference/rest/v1/projects.regions.workflowTemplates/instantiateInline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22062: Patch Dataproc documentation
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #22062:
URL: https://github.com/apache/airflow/pull/22062#issuecomment-1061165374
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #22062: Patch Dataproc documentation
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #22062:
URL: https://github.com/apache/airflow/pull/22062#issuecomment-1061283281
What do you think about fixing a link AND adding a new reference to our guide?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22062: Add guide for DataprocInstantiateInlineWorkflowTemplateOperator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #22062:
URL: https://github.com/apache/airflow/pull/22062#issuecomment-1062101928
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22062: Patch Dataproc documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22062:
URL: https://github.com/apache/airflow/pull/22062#issuecomment-1061203053
Failing tests and static checks :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22062: Add guide for DataprocInstantiateInlineWorkflowTemplateOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22062:
URL: https://github.com/apache/airflow/pull/22062#issuecomment-1062101987
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org