You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/16 03:22:07 UTC

[GitHub] [incubator-nuttx] ryanoabel opened a new pull request #5009: fix: Correct issues with userled support on the Nucleo F4x1RE.

ryanoabel opened a new pull request #5009:
URL: https://github.com/apache/incubator-nuttx/pull/5009


   ## Summary
   Correct issues with userled support on the Nucleo F4x1RE.  
   
   Specifically:
      The proper headers are included when CONFIG_USERLED is defined.
      LED_DRIVER_PATH is set when CONFIG_USERLED_LOWER is defined and CONFIG_ARCH_LEDS is NOT defined.
      board_userled() is corrected for the nucleo-f4x1re.
      board_userled_getall() is implemented for the nucleo-f4x1re.
      userled_lower_initialize() is called when properly configured.
      some comments added.
      
   ## Impact
   userled support on the Nucleo F4x1RE will work properly for the Nucleo F4x1RE.  No other impacts.
   
   ## Testing
   tested and verified on the Nucleo F4x1RE.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #5009: fix: Correct issues with userled support on the Nucleo F4x1RE.

Posted by GitBox <gi...@apache.org>.

acassis commented on pull request #5009:
URL: https://github.com/apache/incubator-nuttx/pull/5009#issuecomment-995613549


   Hi @ryanoabel please fix these issues:
   ```
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32/nucleo-f4x1re/src/stm32_bringup.c:86:1: error: Missing blank line after comment
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32/nucleo-f4x1re/src/stm32_userleds.c:167:5: error: Space follows left parenthesis
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5009: fix: Correct issues with userled support on the Nucleo F4x1RE.

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 merged pull request #5009:
URL: https://github.com/apache/incubator-nuttx/pull/5009


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5009: fix: Correct issues with userled support on the Nucleo F4x1RE.

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 commented on pull request #5009:
URL: https://github.com/apache/incubator-nuttx/pull/5009#issuecomment-996893916


   @ryanoabel could  you squash to one commit?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org